server: split thread_local_object.h and overload_manager.h #13999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting these will prevent circular dependencies when the Dispatcher references thread-local overload state. Signed-off-by: Alex Konradi <[email protected]>
akonradi
requested review from
lizan,
mattklein123 and
PiotrSikora
as code owners
antoniovicente
previously approved these changes
Nov 12, 2020
Signed-off-by: Alex Konradi <[email protected]>
antoniovicente
approved these changes
Nov 12, 2020
|
Waiting for CI to finish and merging since this PR has no functional changes, just changes the location of interfaces to avoid cyclic dependencies between interface libraries after some upcoming changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: refactor thread_local_object.h and overload_manager.h
Additional Description:
Move the interfaces declared in these files into separate files to allow the
Dispatcher to reference the ThreadLocalOverloadState.
For #13800
Risk Level: low, just refactoring
Testing: ran affected test targets
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: none
/assign @antoniovicente