wasm: stop iteration if local response sent #13873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves envoyproxy#13857 Signed-off-by: mathetake <[email protected]>
PiotrSikora
reviewed
Nov 3, 2020
| @@ -425,6 +425,7 @@ class Context : public proxy_wasm::ContextBase, | |||
|
|
|||
| // HTTP filter state. | |||
| bool http_request_started_ = false; // When decodeHeaders() is called the request is "started". | |||
| bool http_local_response_sent_ = false; // indicates if the local response is sent | |||
There was a problem hiding this comment.
Is this the only case when this can happen or should we call it something more general?
| @@ -1579,9 +1580,12 @@ Http::FilterHeadersStatus Context::decodeHeaders(Http::RequestHeaderMap& headers | |||
| request_headers_ = &headers; | |||
| end_of_stream_ = end_stream; | |||
| auto result = convertFilterHeadersStatus(onRequestHeaders(headerSize(&headers), end_stream)); | |||
| if (result == Http::FilterHeadersStatus::Continue) { | |||
| if (http_local_response_sent_) { | |||
| return Http::FilterHeadersStatus::StopIteration; | |||
There was a problem hiding this comment.
Could you move the override into convertFilter{Headers,Data,Trailers}Status() calls instead of doing it inline?
|
moved to proxy-wasm/proxy-wasm-cpp-host#88 so I'm closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mathetake [email protected]
resolves #13857