dependencies: CVE scanner for repository_locations.bzl metadata. #13552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a custom CVE scanner that consumes the NIST CVE database and heuristically matches against the CPEs, versions and last update stamps in repository_locations.bzl. Future PRs will create a CI job that runs this on a periodic basis (every few hours) to provide a CVE early warning system. Example output: Based on heuristic matching with the NIST CVE database, Envoy may be vulnerable to: CVE ID: CVE-2019-19391 CVSS v3 score: 9.1 Severity: CRITICAL Published date: 2019-11-29 Last modified date: 2019-12-19 Dependencies: com_github_luajit_luajit Description: ** DISPUTED ** In LuaJIT through 2.0.5, as used in Moonjit before 2.1.2 and other products, debug.getinfo has a type confusion issue that leads to arbitrary memory write or read operations, because certain cases involving valid stack levels and > options are mishandled. NOTE: The LuaJIT project owner states that the debug libary is unsafe by definition and that this is not a vulnerability. When LuaJIT was originally developed, the expectation was that the entire debug library had no security guarantees and thus it made no sense to assign CVEs. However, not all users of later LuaJIT derivatives share this perspective. Affected CPEs: - cpe:2.3:a:moonjit_project:moonjit:* - cpe:2.3:a:luajit:luajit:* Risk level: Low Testing: cve_scan_test.py unit tests, manual. Signed-off-by: Harvey Tuch <[email protected]>
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Harvey Tuch <[email protected]>
Signed-off-by: Harvey Tuch <[email protected]>
moderation
reviewed
Oct 14, 2020
| @@ -412,6 +412,8 @@ elif [[ "$CI_TARGET" == "docs" ]]; then | |||
| # Validate dependency relationships between core/extensions and external deps. | |||
| tools/dependency/validate_test.py | |||
| tools/dependency/validate.py | |||
| # Validate the CVE scanner works. TODO(htuch): create a dedicated tools CI target. | |||
| python3.8 tools/dependency/cve_scan_test.py | |||
There was a problem hiding this comment.
Does this need the python3.8 ?
There was a problem hiding this comment.
Yeah, the datetime methods we use are more recent.
|
Looks great and will need the |
|
@lizan friendly ping on review. |
lizan
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a custom CVE scanner that consumes the NIST CVE database and
heuristically matches against the CPEs, versions and last update stamps
in repository_locations.bzl.
Future PRs will create a CI job that runs this on a periodic basis
(every few hours) to provide a CVE early warning system.
Example output:
Based on heuristic matching with the NIST CVE database, Envoy may be vulnerable to:
CVE ID: CVE-2019-19391
CVSS v3 score: 9.1
Severity: CRITICAL
Published date: 2019-11-29
Last modified date: 2019-12-19
Dependencies: com_github_luajit_luajit
Description: ** DISPUTED ** In LuaJIT through 2.0.5, as used in Moonjit before
2.1.2 and other products, debug.getinfo has a type confusion issue
that leads to arbitrary memory write or read operations, because
certain cases involving valid stack levels and > options are
mishandled. NOTE: The LuaJIT project owner states that the debug
libary is unsafe by definition and that this is not a vulnerability.
When LuaJIT was originally developed, the expectation was that the
entire debug library had no security guarantees and thus it made no
sense to assign CVEs. However, not all users of later LuaJIT
derivatives share this perspective.
Affected CPEs:
Risk level: Low
Testing: cve_scan_test.py unit tests, manual.
Signed-off-by: Harvey Tuch [email protected]