Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Adding lazy map threshold config to headermap fuzzer #13402

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

adisuissa
Copy link
Contributor

Signed-off-by: Adi Suissa-Peleg [email protected]

Commit Message: fuzz: Adding lazy map threshold config to headermap fuzzer
Additional Description:
Adding a configuration parameter to the headermap fuzzer testing the lazy-headermap.

Risk Level: Low (tests only)
Testing: Adding to a fuzzer
Docs Changes: None.
Release Notes: None.

@adisuissa
Copy link
Contributor Author

@asraa please take a look

@asraa asraa self-assigned this Oct 6, 2020
@asraa
Copy link
Contributor

asraa commented Oct 6, 2020

Thanks! Could you take a quick look at compile_time_options?

@adisuissa
Copy link
Contributor Author

Ok, that was strange.
Building with clang's libc++ (--stdlib=libc++) doesn't trigger the assertion, but when building with GCC's it does.
The remove_if code where the assertion has triggered was recently updated (merged latest main), and by using both libraries no assertion failed.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very weird! I suppose I will keep that mind in case something else ever comes up with GCC builds.

Thank you :) LGTM!

@asraa asraa merged commit 850a0f2 into envoyproxy:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants