Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/ci: Update config validation #13387

Merged
merged 6 commits into from
Oct 5, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 3, 2020

Signed-off-by: Ryan Northey [email protected]

Commit Message: docs/ci: Update config validation
Additional Description:

  • some config snippets in docs were separated from .rst files, some of these can be checked with config validation (with some small modifications). Some fail - so will follow up in subsequent PR to address failing configs
  • use glob/exclusions for matching config files in examples/BUILD
  • remove verify_build_configs as configs are found dynamically
  • cleanup indentation on docs configs

Risk Level: low
Testing: yep
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@phlax phlax marked this pull request as draft October 3, 2020 18:20
@phlax phlax changed the title [WIP] docs/ci: Add config docs config snippets to config validation [WIP] docs/ci: Add docs config snippets to config validation Oct 3, 2020
@phlax phlax changed the title [WIP] docs/ci: Add docs config snippets to config validation [WIP] docs/ci: Update config validation Oct 4, 2020
@phlax phlax force-pushed the docs-config-validation branch 2 times, most recently from 0dc600a to d48d2ae Compare October 4, 2020 07:33
@phlax phlax force-pushed the docs-config-validation branch from d628975 to 48b24d5 Compare October 4, 2020 10:40
@phlax phlax marked this pull request as ready for review October 4, 2020 10:42
@phlax phlax changed the title [WIP] docs/ci: Update config validation docs/ci: Update config validation Oct 4, 2020
@mattklein123 mattklein123 self-assigned this Oct 4, 2020
docs/BUILD Outdated Show resolved Hide resolved
@phlax phlax force-pushed the docs-config-validation branch 2 times, most recently from b53f3f2 to 3f914af Compare October 5, 2020 06:59
@phlax
Copy link
Member Author

phlax commented Oct 5, 2020

/retest-circle

@repokitteh-read-only
Copy link

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #13387 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the docs-config-validation branch from 3f914af to 3457b52 Compare October 5, 2020 10:15
@phlax
Copy link
Member Author

phlax commented Oct 5, 2020

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks. Just one small question/comment.

/wait

docs/BUILD Show resolved Hide resolved
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit bfe8de1 into envoyproxy:master Oct 5, 2020
@phlax phlax mentioned this pull request Oct 7, 2020
lizan pushed a commit that referenced this pull request Oct 16, 2020
some configs in docs were initially excluded from validation (in #13387) - this PR will remove the exclusions where possible

Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants