-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/ci: Update config validation #13387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
0dc600a
to
d48d2ae
Compare
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
d628975
to
48b24d5
Compare
phlax
commented
Oct 5, 2020
b53f3f2
to
3f914af
Compare
/retest-circle |
🤷♀️ nothing to rebuild. |
Signed-off-by: Ryan Northey <[email protected]>
3f914af
to
3457b52
Compare
mattklein123
requested changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks. Just one small question/comment.
/wait
Signed-off-by: Ryan Northey <[email protected]>
mattklein123
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
lizan
pushed a commit
that referenced
this pull request
Oct 16, 2020
some configs in docs were initially excluded from validation (in #13387) - this PR will remove the exclusions where possible Signed-off-by: Ryan Northey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message: docs/ci: Update config validation
Additional Description:
.rst
files, some of these can be checked with config validation (with some small modifications). Some fail - so will follow up in subsequent PR to address failing configsexamples/BUILD
verify_build_configs
as configs are found dynamicallyRisk Level: low
Testing: yep
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]