common: fix -Wrange-loop-analysis error on Envoy Mobile
#13342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy Mobile is failing compilation with this error:
```
external/envoy/source/common/http/header_map_impl.cc:506:23: error: loop variable 'values_it' of type 'const std::__1::__list_iterator<Envoy::Http::HeaderMapImpl::HeaderEntryImpl, void *>' creates a copy from type 'const std::__1::__list_iterator<Envoy::Http::HeaderMapImpl::HeaderEntryImpl, void *>' [-Werror,-Wrange-loop-analysis]
for (const auto values_it : v) {
^
external/envoy/source/common/http/header_map_impl.cc:506:12: note: use reference type 'const std::__1::__list_iterator<Envoy::Http::HeaderMapImpl::HeaderEntryImpl, void *> &' to prevent copying
for (const auto values_it : v) {
^~~~~~~~~~~~~~~~~~~~~~
&
```
This regression was introduced in envoyproxy@442b3f1.
Signed-off-by: Michael Rebello <[email protected]>
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy Mobile is failing compilation with this error:
This regression was introduced in 442b3f1.
We're tracking enabling this rule on Envoy builds in #13154, but it's currently blocked.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Signed-off-by: Michael Rebello [email protected]