http: add CDN-Loop header filter #13158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CdnLoopFilter implements an HTTP filter that detects and prevents CDN loops using the RFC 8586 CDN-Loop header. The filter can be configured with the CDN identifier to look for as well as the number of times the CDN identifier can be seen before responding with an error. Risk Level: Low Testing: bazel test //test/extensions/filters/http/cdn_loop/... Docs Changes: N/A Release Notes: added note about new filter Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
This removes: checking consistency... /source/generated/rst/api-v3/extensions/filters/http/cdn_loop/v3alpha/cdn_loop.proto.rst: WARNING: document isn't included in any toctree from the docs CI. Signed-off-by: Justin Mazzola Paluska <[email protected]>
htuch
reviewed
Sep 21, 2020
alyssawilk
reviewed
Sep 21, 2020
api/envoy/extensions/filters/http/cdn_loop/v3alpha/cdn_loop.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
Why does the formatter hate two spaces after a period? Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
/source/generated/rst/configuration/http/http_filters/cdn_loop.rst:16: WARNING: Unexpected indentation. /source/generated/rst/configuration/http/http_filters/cdn_loop.rst:13: WARNING: Inline interpreted text or phrase reference start-string without end-string. /source/generated/rst/configuration/http/http_filters/cdn_loop.rst:28: WARNING: Unexpected indentation. /source/generated/rst/configuration/http/http_filters/cdn_loop.rst:30: WARNING: Block quote ends without a blank line; unexpected unindent. Signed-off-by: Justin Mazzola Paluska <[email protected]>
Signed-off-by: Justin Mazzola Paluska <[email protected]>
alyssawilk
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Docs look great, thanks!
regarding perf, I think a benchmark with some pathologically complex headers? Basically if the cdn loop header is the largest allowed by Envoy header limits, we want to make sure it's not N^2 expensive. But as said that can all be in a follow-up
Signed-off-by: Justin Mazzola Paluska <[email protected]>
This gets us the automatic coalescing we want. Signed-off-by: Justin Mazzola Paluska <[email protected]>
alyssawilk
reviewed
Sep 23, 2020
There was a problem hiding this comment.
Looks good modulo two minor test nits!
@snowp would you be up for the non-google pass?
test/extensions/filters/http/cdn_loop/filter_integration_test.cc
Outdated
Show resolved
Hide resolved
alyssawilk
previously approved these changes
Sep 23, 2020
Signed-off-by: Justin Mazzola Paluska <[email protected]>
snowp
suggested changes
Sep 23, 2020
Signed-off-by: Justin Mazzola Paluska <[email protected]>
snowp
approved these changes
Sep 24, 2020
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CdnLoopFilter implements an HTTP filter that detects and prevents
CDN loops using the RFC 8586 CDN-Loop header. The filter can be
configured with the CDN identifier to look for as well as the number
of times the CDN identifier can be seen before responding with an
error.
Fixes #8183.
Risk Level: Low
Testing: bazel test //test/extensions/filters/http/cdn_loop/...
Docs Changes: N/A
Release Notes: added note about new filter
Signed-off-by: Justin Mazzola Paluska [email protected]