Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer impl: add cast for android compilation #12583

Merged
merged 1 commit into from
Aug 11, 2020
Merged

buffer impl: add cast for android compilation #12583

merged 1 commit into from
Aug 11, 2020

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Aug 10, 2020

Commit Message: add cast for android compilation
Additional Description: #12439 added a return value that had issues with implicit narrowing when building envoy mobile for android. This explicit cast fixes the build issues.
Risk Level: low using the expected type for the constructor as the static_cast type.
Testing: local build of envoy mobile for android. CI

Signed-off-by: Jose Nino [email protected]

@junr03
Copy link
Member Author

junr03 commented Aug 10, 2020

@roelfdutoit can you take a look?

@junr03 junr03 merged commit 689bd37 into envoyproxy:master Aug 11, 2020
@antoniovicente
Copy link
Contributor

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants