build: Fix that selective testing does not work #12563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you know that the envoy build system has a functionality that can choose some tests to do test manually. But now, to do that, I need to add a dummy argument when I execute the do_ci.sh like as following: /ci/run_envoy_docker.sh "./ci/do_ci.sh bazel.dev '' //test/common/network:udp_listener_impl_test". So, this patch fixes that selective testing works like as previous behavior. Signed-off-by: DongRyeol Cha <[email protected]>
lizan
approved these changes
Aug 10, 2020
|
Thanks I think this is a regression from #12458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
As you know that the envoy build system has a functionality that can choose some tests
to do test manually.
But now, to do that, I need to add a dummy argument when I execute the do_ci.sh
like as following:
/ci/run_envoy_docker.sh "./ci/do_ci.sh bazel.dev '' //test/common/network:udp_listener_impl_test".
So, this patch fixes that selective testing works like as previous behavior.
Signed-off-by: DongRyeol Cha [email protected]
Additional Description: None
Risk Level: Low
Testing: bazel test
Docs Changes: None
Release Notes: None