api: add node field to csds request

[Rainton]

Commit Message: added an node field to csds request to identify the CSDS client to the CSDS server, and removed the [#not-implemented-hide:] for the endpoint_config since it has been implemented in #11577
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Yutong Li [email protected]
/cc @fuqianggao @alexburnos

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12522 was opened by Rainton.

see: more, trace.

[markdroth]

I don't understand why this is needed. There's already a way to match on the node ID field in the NodeMatcher message:

envoy/api/envoy/type/matcher/v3/node.proto

Line 24 in cf85068

StringMatcher node_id = 1;

[markdroth]

As per offline discussion, it seems like what you want here is not a way to select the data that you want CSDS to return but rather a way to identify the CSDS client to the CSDS server. In that case, I suspect the right way to do it is to add a Node message, not just a single string id field.

That having been said, I'm not actually all that familiar with how CSDS is used, so I'm going to defer to @htuch or one of the other API shephards to review this.

[htuch]

Yes, I think this probably belongs in the Node ID or metadata.

[Rainton]

@markdroth @htuch Just want to make sure that what you suggested is replacing the string id field by a Node filed just like which in DiscoveryRequest, right?

[markdroth]

Yes, exactly.

[htuch]

Yeah, it seems reasonable to re-use this structure if we consider nodes to be Envoy/gRPC clients, intermediaries such as proxies, CSDS, etc.

[Rainton]

@markdroth @htuch Thanks for the suggestion! I've modified the csds request by adding a node field to it and also edited the commit message.

/cc @fuqianggao

[htuch]

LGTM

[markdroth]

/lgtm api