Fix 4 test failures due to broken CRLF line handling on Windows #12381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test/test_common/environment.cc was reading config files for substitution in binary (preserving \r) and then writing the substituted resulting file in text (replacing \n with \r\n), ending up with \r\r\n line endings. - //test/common/runtime:runtime_impl_test now generates multiline strings on the fly to ensure line endings are treated in string as a binary blob Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
…space Signed-off-by: William A Rowe Jr <[email protected]>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
- test/test_common/environment.cc was reading config files for substitution in binary (preserving \r) and then writing the substituted resulting file in text (replacing \n with \r\n), ending up with \r\r\n line endings. - //test/common/runtime:runtime_impl_test now generates multiline strings on the fly to ensure line endings are treated in string as a binary blob Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
- test/test_common/environment.cc was reading config files for substitution in binary (preserving \r) and then writing the substituted resulting file in text (replacing \n with \r\n), ending up with \r\r\n line endings. - //test/common/runtime:runtime_impl_test now generates multiline strings on the fly to ensure line endings are treated in string as a binary blob Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: chaoqinli <[email protected]>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
- test/test_common/environment.cc was reading config files for substitution in binary (preserving \r) and then writing the substituted resulting file in text (replacing \n with \r\n), ending up with \r\r\n line endings. - //test/common/runtime:runtime_impl_test now generates multiline strings on the fly to ensure line endings are treated in string as a binary blob Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: chaoqinli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Fix 4 test failures due to broken CRLF line handling on Windows
Additional Description:
test/test_common/environment.cc was reading config files for
substitution in binary (preserving \r) and then writing the
substituted resulting file in text (replacing \n with \r\n),
ending up with \r\r\n line endings.
//test/common/runtime:runtime_impl_test now generates multiline
strings on the fly to ensure line endings are treated in string
as a binary blob
Co-authored-by: Sunjay Bhatia [email protected]
Co-authored-by: William A Rowe Jr [email protected]
Signed-off-by: Sunjay Bhatia [email protected]
Signed-off-by: William A Rowe Jr [email protected]
Risk Level: Low to Windows, None to Unix
Testing: Local on Windows
Docs Changes: n/a
Release Notes: n/a