V2 TO V3 fragment changes for extension and server directory under test/.. #12058
Conversation
ankatare
requested review from
alyssawilk,
lizan,
mattklein123,
PiotrSikora,
snowp and
zuercher
as code owners
ankatare
force-pushed
the
v2_to_v3_fragment_changes_extensions_directory
branch
from
e9f94ea to
937e11d
Compare
|
@junr03 seems some env issues in this PR. please suggest if it is good to go with code review. |
|
Try merging master again? |
ankatare
force-pushed
the
v2_to_v3_fragment_changes_extensions_directory
branch
from
937e11d to
7a61a59
Compare
|
@junr03 ok. |
Signed-off-by: Abhay Narayan Katare <[email protected]>
ankatare
force-pushed
the
v2_to_v3_fragment_changes_extensions_directory
branch
from
7a61a59 to
588b1aa
Compare
Signed-off-by: Abhay Narayan Katare <[email protected]>
|
@junr03 merged from master. again seems some different env issues. please suggest if it is ok to review code. |
|
@ankatare looks like a valid clang-tidy failure. Not because of your change. The file was already invalid, but changing it made it so that clang-tidy ran over it and detected already existing failures. Do you mind fixing? |
|
@junr03 sure, please suggest how to fix it , any pointers would be helpful. |
|
@junr03 i tried below command to fix issue |
|
@ankatare what is the failure trace? |
test/extensions/filters/network/thrift_proxy/filters/ratelimit/ratelimit_test.cc
Outdated
Show resolved
Hide resolved
ankatare
force-pushed
the
v2_to_v3_fragment_changes_extensions_directory
branch
4 times, most recently
from
fad74c0 to
951c1df
Compare
Signed-off-by: Abhay Narayan Katare <[email protected]>
ankatare
force-pushed
the
v2_to_v3_fragment_changes_extensions_directory
branch
from
951c1df to
6c96003
Compare
|
@junr03 Build completed with master in sync and resolved clang-tidy issues. please review. |
…st/.. (envoyproxy#12058) Commit Message: v2 to v3 fragment changes for extension and server directory test cases. Risk Level: Low Testing: unit and format Fixes envoyproxy#10843 Signed-off-by: Abhay Narayan Katare <[email protected]>
…st/.. (envoyproxy#12058) Commit Message: v2 to v3 fragment changes for extension and server directory test cases. Risk Level: Low Testing: unit and format Fixes envoyproxy#10843 Signed-off-by: Abhay Narayan Katare <[email protected]> Signed-off-by: chaoqinli <[email protected]>
Signed-off-by: Abhay Narayan Katare [email protected]
Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Additional Description:
Risk Level: Low
Testing: unit and format
Docs Changes:NA
Release Notes: NA
[Optional Runtime guard:]
Optional Fixes #10843
[Optional Deprecated:]