Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ext_authz_fuzzer] cleaned up the try-catch logic #12055

Merged
merged 4 commits into from
Jul 15, 2020
Merged

[ext_authz_fuzzer] cleaned up the try-catch logic #12055

merged 4 commits into from
Jul 15, 2020

Conversation

jianwen612
Copy link
Contributor

Additional Description:

  1. Fixed the style in protobuf file: Added a new line.
  2. Cleaned up the try-catch logic in the fuzz test.
    Risk Level: low

/cc @asraa
/cc @samkerner

@jianwen612 jianwen612 requested a review from dio as a code owner July 13, 2020 14:41
@jianwen612 jianwen612 marked this pull request as draft July 13, 2020 14:42
@jianwen612 jianwen612 marked this pull request as ready for review July 13, 2020 14:59
asraa
asraa approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. We eventually catch a general EnvoyException if filter chain creation fails (including because of a validation error)

@asraa asraa merged commit 4cd3510 into envoyproxy:master Jul 15, 2020
sqkerner
sqkerner reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@sqkerner sqkerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
@jianwen612 @KBaichoo
[ext_authz_fuzzer] cleaned up the try-catch logic (envoyproxy#12055)
3600ef0 
Fixed the style in ext_authz fuzzer protobuf file: Added a new line.
Cleaned up the try-catch logic in the fuzz test.

Signed-off-by: jianwen <[email protected]>
Signed-off-by: Kevin Baichoo <[email protected]>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
@jianwen612
[ext_authz_fuzzer] cleaned up the try-catch logic (envoyproxy#12055)
cb8a375 
Fixed the style in ext_authz fuzzer protobuf file: Added a new line.
Cleaned up the try-catch logic in the fuzz test.

Signed-off-by: jianwen <[email protected]>
Signed-off-by: scheler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqkerner sqkerner sqkerner left review comments

@asraa asraa asraa approved these changes

@dio dio Awaiting requested review from dio

Assignees

@asraa asraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianwen612 @asraa @sqkerner