V2 to V3 fragment changes for http and access_log folders under test/.. #12027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ankatare do you mind editing to a more descriptive title and description. Also looks like tests are failing? |
|
/wait |
ankatare
changed the title
|
@junr03 Hi, thanks for review. i updated details ( title and description ) as per suggestions. regarding test cases failing in CI it seems environment issues in build. please help. |
|
@junr03 i checked the code which is failing. i have not touched it while working and also that test file "test/common/access_log/access_log_impl_test.cc"is passing in my local build. please suggest how to proceed here. |
|
@ankatare do you mind merging master again? We have had some CI issues, but it should be resolved on master now. |
|
@junr03 Sure , i will do it ASAP . thanks for help. |
ankatare
requested review from
alyssawilk,
dio,
htuch,
jmarantz,
junr03,
lizan,
mattklein123,
PiotrSikora,
snowp and
zuercher
as code owners
ankatare
force-pushed
the
v2_to_v3_changes_for_http_and_accesslog_folder
branch
from
708d425 to
6bbe623
Compare
Signed-off-by: Abhay Narayan Katare <[email protected]>
ankatare
force-pushed
the
v2_to_v3_changes_for_http_and_accesslog_folder
branch
from
6bbe623 to
e53a04b
Compare
|
@junr03 done. please review |
junr03
approved these changes
Jul 18, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Commit Message: changes for http and access_log folders Risk Level:NA Testing: Unit and format testing Docs Changes: NA part of envoyproxy#10843 Signed-off-by: Abhay Narayan Katare <[email protected]> Signed-off-by: Kevin Baichoo <[email protected]>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Commit Message: changes for http and access_log folders Risk Level:NA Testing: Unit and format testing Docs Changes: NA part of envoyproxy#10843 Signed-off-by: Abhay Narayan Katare <[email protected]> Signed-off-by: scheler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhay Narayan Katare [email protected]
Commit Message: changes for http and access_log folders
Additional Description: V2 to V3 APIs fragment changes and forcing ParseFoofromV2Yaml for V3. this commit focuses on changes for http and access_log folders under test/common/..
Risk Level:NA
Testing: Unit and format testing
Docs Changes: NA
Release Notes:
[Optional Runtime guard:]
[Optional Fixes:]
[Optional Deprecated:]
part of #10843