router: add regex substitution to header hashing #11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when you need to hash on a transformation of a header value (e.g.: extract a part of `:path`). Fixes envoyproxy#11811 Signed-off-by: Raul Gutierrez Segales <[email protected]>
|
/lgtm api |
Sort. Signed-off-by: Raul Gutierrez Segales <[email protected]>
|
Hmm failure looks unrelated (on the windows build): |
|
Another unrelated timeout: |
|
re: windows: 83841da |
|
re: timeout, probably this one: #11842. |
|
/azp run envoy-presubmit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Extend hashing via header to support regex substitution.
Additional Description:
This is useful when you need to hash on a transformation
of a header value (e.g.: extract a part of
:path).Fixes #11811
Risk Level: low
Testing: unit test added
Docs Changes: none
Release Notes: added
Signed-off-by: Raul Gutierrez Segales [email protected]