http: fix and generalize PercentEncoding utility. #11677
Merged
+24
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix an off-by-one bug in PercentEncoding::encode(). It doesn't appear that this utility is used anywhere that this would be security sensitive, but it is used for sendLocalReply() for gRPC messages. * Generalize from '%' to arbitrary visible reserved chars. RFC3986 encoding requires more flexibility, e.g. being able to percent encode `/` or `#`. This change was motivated by a larger patch that provides encoding/decoding of udpa:// URIs, as part of envoyproxy#11264. Risk level: Low Testing: Additional unit tests. Signed-off-by: Harvey Tuch <[email protected]>
|
/azp run envoy-presubmit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -158,7 +161,8 @@ class PercentEncoding { | |||
|
|
|||
| private: | |||
| // Encodes string view to its percent encoded representation, with start index. | |||
| static std::string encode(absl::string_view value, const size_t index); | |||
| static std::string encode(absl::string_view value, const size_t index, | |||
| const absl::flat_hash_set<char>& reserved_char_set); | |||
There was a problem hiding this comment.
Are there tests or uses of this function? If not, we should delete it.
There was a problem hiding this comment.
Nevermind, this helper function is used internally by encode, which does a scan first.
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
* Fix an off-by-one bug in PercentEncoding::encode(). It doesn't appear that this utility is used anywhere that this would be security sensitive, but it is used for sendLocalReply() for gRPC messages. * Generalize from '%' to arbitrary visible reserved chars. RFC3986 encoding requires more flexibility, e.g. being able to percent encode `/` or `#`. This change was motivated by a larger patch that provides encoding/decoding of udpa:// URIs, as part of envoyproxy#11264. Risk level: Low Testing: Additional unit tests. Signed-off-by: Harvey Tuch <[email protected]>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
* Fix an off-by-one bug in PercentEncoding::encode(). It doesn't appear that this utility is used anywhere that this would be security sensitive, but it is used for sendLocalReply() for gRPC messages. * Generalize from '%' to arbitrary visible reserved chars. RFC3986 encoding requires more flexibility, e.g. being able to percent encode `/` or `#`. This change was motivated by a larger patch that provides encoding/decoding of udpa:// URIs, as part of envoyproxy#11264. Risk level: Low Testing: Additional unit tests. Signed-off-by: Harvey Tuch <[email protected]> Signed-off-by: yashwant121 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an off-by-one bug in PercentEncoding::encode(). It doesn't appear that this utility is used
anywhere that this would be security sensitive, but it is used for sendLocalReply() for gRPC
messages.
Generalize from '%' to arbitrary visible reserved chars. RFC3986 encoding requires more
flexibility, e.g. being able to percent encode
/or#.This change was motivated by a larger patch that provides encoding/decoding of udpa:// URIs, as part
of #11264.
Risk level: Low
Testing: Additional unit tests.
Signed-off-by: Harvey Tuch [email protected]