network: move socket type from address to socket

[florincoras]

Signed-off-by: Florin Coras [email protected]

Risk Level: Low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a

[ggreenway]

I know this change follows the bsd socket API, but I think the code is clearer having the type attached to the address. I think it's clearer that 127.0.0.1:80 cannot point to both TCP and UDP; a different address is needed for the two.

[florincoras]

Ultimately this is a cosmetic change, so I guess it's not worth wasting too much time on it. However, I'm not sure I follow the above example. We are already storing the socket type in the socket, it's just that we're using a type defined in address.

Also, if one wants to open two tcp connections to 127.0.0.1:80, two addresses are needed but the above distinction does not hold anymore.

[ggreenway]

Sorry, I didn't look closely enough before I commented.

Yes, given that this is just moving the type definition, I agree it makes sense.

[florincoras]

No worries! Thanks, @ggreenway !