build: use rules_cc and use buildifier -lint to enforce it #11399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
lizan
requested review from
alyssawilk,
dio,
htuch,
jmarantz,
junr03,
mattklein123,
PiotrSikora,
snowp and
zuercher
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
Note to reviewer: please only review the first commit, the second one is generated by fix_format. |
htuch
previously approved these changes
Jun 2, 2020
| @@ -61,12 +61,12 @@ def fixFileExpectingSuccess(file, extra_input_files=None): | |||
| command, infile, outfile, status, stdout = fixFileHelper(file, | |||
| extra_input_files=extra_input_files) | |||
| if status != 0: | |||
| print("FAILED:") | |||
| print("FAILED:" + infile) | |||
Signed-off-by: Lizan Zhou <[email protected]>
|
@htuch done, I need v2-api LGTM too :) |
|
/lgtm v2-freeze |
htuch
approved these changes
Jun 2, 2020
auni53
pushed a commit
to auni53/envoy
that referenced
this pull request
Jun 4, 2020
…y#11399) Commit Message: Partially address envoyproxy#9488. Resurrected envoyproxy#10597. Additional Description: Risk Level: Low Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <[email protected]> Signed-off-by: Auni Ahsan <[email protected]>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
…y#11399) Commit Message: Partially address envoyproxy#9488. Resurrected envoyproxy#10597. Additional Description: Risk Level: Low Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <[email protected]> Signed-off-by: yashwant121 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Partially address #9488. Resurrected #10597.
Additional Description:
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A