connect: docs and cleanup #11146
connect: docs and cleanup #11146
Conversation
Signed-off-by: Alyssa Wilk <[email protected]>
|
cc @htuch for can we mark features alpha? |
Signed-off-by: Alyssa Wilk <[email protected]>
|
@alyssawilk not yet, but once #11151 merges we can build something very similar without much work to support this. Meanwhile, you can create an issue around this and assign to me if you'd like. |
|
In the interim do you think it's worth a comment, or do you think it's implicit that new features aren't well vetted? |
|
Yes, comment is fine, and please add a |
|
|
||
| [SMTP Upstream] --- raw SMTP --- [L2 Envoy] --- SMTP tunneled over HTTP/2 --- [L1 Envoy] --- raw SMTP --- [Client] | ||
|
|
||
| Examples of such a set up can be found in the Envoy example config `directory <https://github.com/envoyproxy/envoy/tree/master/configs/>` |
There was a problem hiding this comment.
Please us a :repo: link here.
Signed-off-by: Alyssa Wilk <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alyssa Wilk <[email protected]>
| [SMTP Upstream] --- raw SMTP --- [L2 Envoy] --- SMTP tunneled over HTTP/2 --- [L1 Envoy] --- raw SMTP --- [Client] | ||
|
|
||
| Examples of such a set up can be found in the Envoy example config :repo:`directory <configs/>` | ||
| If you run `bazel-bin/source/exe/envoy-static --config-path configs/encapsulate_in_connect.yaml --base-id 1` |
There was a problem hiding this comment.
configs/encapsulate_in_connect.v3.yaml
|
|
||
| Examples of such a set up can be found in the Envoy example config :repo:`directory <configs/>` | ||
| If you run `bazel-bin/source/exe/envoy-static --config-path configs/encapsulate_in_connect.yaml --base-id 1` | ||
| and `bazel-bin/source/exe/envoy-static --config-path configs/terminate_connect.yaml` |
There was a problem hiding this comment.
configs/terminate_connect.v3.yaml
There was a problem hiding this comment.
whoops - good catch!
#11175
Un-hiding CONNECT docs and config, now that it is implemented.
Risk Level: low (docs only)
Testing: in prior PRs
Docs Changes: yes
Release Notes: yes
Fixes #1630 and #1451