coverage: use lcov to merge multi-binary coverage report #10909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
…rage Signed-off-by: Lizan Zhou <[email protected]>
stale
bot
removed
the
stale
…rage Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
…rage Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
…rage Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
lizan
force-pushed
the
multi_binary_coverage
branch
from
d3222fb to
7dc3d6b
Compare
Signed-off-by: Lizan Zhou <[email protected]>
asraa
reviewed
May 13, 2020
There was a problem hiding this comment.
Thank you so much! The fuzz wrapper is unbelievably clean, TIL about --run_under.
Will look into stat merger fuzzing issue discussed offline https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21460
Signed-off-by: Lizan Zhou <[email protected]>
asraa
reviewed
May 14, 2020
Signed-off-by: Lizan Zhou <[email protected]>
asraa
approved these changes
May 14, 2020
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Oct 21, 2020
Support for coverage with clang in Bazel was half working because the report produced was in a binary format and it wasn't be utilized by the LCOV merger and therefore didn't show up in the final LCOV report. This CL uses llvm-cov as was used by Envoy in envoyproxy/envoy#10909 to produce an LCOV report. To run this the following environment variable and build flags are needed: BAZEL_USE_LLVM_NATIVE_COVERAGE=1 GCOV={path to llvm_profdata} CC=clang \ BAZEL_LLVM_COV={path to llvm_cov} bazel coverage --experimental_generate_llvm_lcov PiperOrigin-RevId: 338254344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use bazel lcov merger to merge coverage generated by
llvm-cov exportfrom multiple binary run. This improves coverage test stability by run them in separate sandbox.Risk Level: Low (test only)
Testing: CI
Docs Changes: N/A
Release Notes: N/A