http/2 graceful drain support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection manager goes into a drain sequence where we issue a shutdown notice, wait 5s, then do a full shutdown.
|
@lyft/network-team |
RomanDzhabarov
approved these changes
Sep 28, 2016
| @@ -100,8 +101,19 @@ idle_timeout_s | |||
| *(optional, integer)* The idle timeout in seconds for connections managed by the connection | |||
| manager. The idle timeout is defined as the period in which there are no active requests. If not | |||
| set, there is no idle timeout. When the idle timeout is reached the connection will be closed. If | |||
| the connection is an HTTP/2 connection a GOAWAY frame will be sent prior to closing | |||
| the connection. | |||
| the connection is an HTTP/2 connection a drain sequence will occur prior to closing the | |||
There was a problem hiding this comment.
nit: tag as config_http_conn_man_drain_timeout_ms
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
yxue
referenced
this pull request
in yxue/envoy
Nov 20, 2019
Signed-off-by: John Plevyak <[email protected]>
shalk
pushed a commit
to shalk/envoy
that referenced
this pull request
Nov 6, 2020
jwendell
pushed a commit
to jwendell/envoy
that referenced
this pull request
Mar 30, 2022
* Add LuaJIT patch for s390x * Move proxy luajit build flags patch to envoy
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection manager goes into a drain sequence where we issue a shutdown
notice, wait 5s, then do a full shutdown.