Tests are now being executed during gcc builds #10236

dmitri-d · 2020-03-03T16:27:31Z

This [re]enables tests during gcc builds.

Please note this PR shouldn't ve merged before envoyproxy/envoy-build-tools#34.

I'm not sure if it's ok to use bazel.gcc target, or a new target should be added, decided to use bazel.gcc in this PR.

Signed-off-by: Dmitri Dolguikh <[email protected]>

lizan · 2020-03-03T21:13:19Z

@dmitri-d merged envoyproxy/envoy-build-tools#34

dmitri-d · 2020-03-09T17:55:16Z

@lizan: could you restart the tests please?

lizan · 2020-03-12T23:22:17Z

/azp run envoy-linux

azure-pipelines · 2020-03-12T23:22:26Z

Azure Pipelines successfully started running 1 pipeline(s).

dmitri-d · 2020-03-17T18:39:56Z

There's two failures due to memory leaks:

*** WARNING: Cannot convert addresses to symbols in output below.
*** Reason: Cannot find 'pprof' (is PPROF_PATH set correctly?)
*** If you cannot fix this, try running pprof directly.
Leak of 8 bytes in 1 objects allocated from:
	@ 40ac9c 
	@ b4b8ad

I tracked them down to static initialiser here: https://github.com/envoyproxy/envoy/blob/master/source/extensions/common/crypto/utility_impl.cc#L105. Not sure what to do about these other than to pass "HEAPCHECK=minimal" to tests. @lizan: WDYT?

Another failure due to quiche build failure (#10422).

stale · 2020-03-24T19:20:31Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dmitri-d · 2020-03-24T22:09:54Z

ping

lizan · 2020-03-25T05:11:17Z

@dmitri-d you need to do the build image update as well to pick up gcc-9, so this can't be in until #10506 is merged.

dmitri-d · 2020-03-26T19:20:31Z

@lizan: could you restart the tests pls?

lizan · 2020-03-26T23:57:01Z

@dmitri-d you need merge master.

Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d · 2020-03-30T18:45:41Z

merged in master

lizan · 2020-03-30T20:39:04Z

some QUIC test failed to build in gcc. cc @danzh2010

dmitri-d · 2020-03-30T21:22:40Z

@lizan: the build fails due to #10422.

stale · 2020-04-07T04:42:34Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale · 2020-04-14T07:03:40Z

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d · 2020-05-12T21:45:17Z

@lizan: could you re-open the PR please? At least one of the quiche-related issues has been resolved.

Signed-off-by: Dmitri Dolguikh <[email protected]>

twghu · 2020-06-26T13:34:50Z

Refer to envoyproxy/nighthawk#382 (comment) for explanation of problem.

stale · 2020-07-03T14:24:18Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: Dmitri Dolguikh <[email protected]>

…uic_listeners/quiche/test_utils.h Signed-off-by: Dmitri Dolguikh <[email protected]>

…:LocalRateLimitFilter::TestOneProtoInput Signed-off-by: Dmitri Dolguikh <[email protected]>

Signed-off-by: Dmitri Dolguikh <[email protected]>

lizan · 2020-07-08T23:09:26Z

test/mocks/config/mocks.h

@@ -94,6 +94,10 @@ class MockGrpcMux : public GrpcMux {
  MockGrpcMux();
  ~MockGrpcMux() override;

+  using GrpcMux::pause;


why did you need this? Does marking MOCK_METHOD below override in 4th parameter (like below) fixes gcc build?

MOCK_METHOD(void, start, (), (override));

lizan · 2020-07-08T23:11:53Z

source/common/common/macros.h

@@ -54,4 +54,7 @@ namespace Envoy {
 #define FALLTHRU
 #endif

+#if (defined(__GNUC__) && !defined(__clang__))


This should be in include/envoy/common/platform.h?

Hmm, the comment in platform.h says:

"platform.h" header exists to simplify the most common references to non-ANSI C/C++ headers, required on Windows, Posix, Linux, BSD etc, and to provide substitute definitions when absolutely required.

feels like not a good spot to me for the macro in question?

OK, I don't feel strongly either.

Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d · 2020-07-08T23:25:41Z

Added 'override' to MockGrpcMux methods implementing the interface

Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d · 2020-07-09T15:21:18Z

@lizan: Not sure why asan failed (all tests passed), otherwise looks good.

Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d · 2020-07-09T19:53:39Z

resolved conflict, merged in latest changes

dmitri-d · 2020-07-10T16:39:53Z

@lizan, the build is green now.

dmitri-d · 2020-07-10T19:29:26Z

Thank you very much for the reviews and feedback, @lizan.

Signed-off-by: Dmitri Dolguikh <[email protected]> Signed-off-by: scheler <[email protected]>

Tests are now being executed during gcc builds

fe673cf

Signed-off-by: Dmitri Dolguikh <[email protected]>

lizan force-pushed the master branch from a9b9f8b to 5b1723f Compare March 3, 2020 18:00

jmarantz assigned lizan Mar 3, 2020

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 24, 2020

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Mar 24, 2020

Merge branch 'master' into enable-gcc-tests

d5eb889

Signed-off-by: Dmitri Dolguikh <[email protected]>

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 7, 2020

stale bot closed this Apr 14, 2020

dmitri-d mentioned this pull request Apr 23, 2020

Another Quiche build failure under gcc #10887

Closed

Merge remote-tracking branch 'upstream/master' into enable-gcc-tests

5aa440b

Signed-off-by: Dmitri Dolguikh <[email protected]>

lizan reopened this May 13, 2020

stale bot removed stale stalebot believes this issue/PR has not been touched recently labels May 13, 2020

Suppress errors due to comparisons of size_t vs int

ed027c6

Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d mentioned this pull request Jun 24, 2020

Add CI setup that builds and tests Nighthawk using gcc envoyproxy/nighthawk#382

Closed

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 3, 2020

Dmitri Dolguikh added 2 commits July 6, 2020 13:42

Merge remote-tracking branch 'upstream' into enable-gcc-tests

9f11d44

Signed-off-by: Dmitri Dolguikh <[email protected]>

resolve hiding of base class methods in MockGrpcMux

8b8f6c7

Signed-off-by: Dmitri Dolguikh <[email protected]>

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 6, 2020

Dmitri Dolguikh added 2 commits July 6, 2020 15:59

Fixed 'control reaches end of non-void function' in test/extensions/q…

65eb171

…uic_listeners/quiche/test_utils.h Signed-off-by: Dmitri Dolguikh <[email protected]>

Catching exception by reference in Envoy::Extensions::NetworkFilters:…

df0965c

…:LocalRateLimitFilter::TestOneProtoInput Signed-off-by: Dmitri Dolguikh <[email protected]>

dmitri-d requested a review from junr03 as a code owner July 7, 2020 00:02

Dmitri Dolguikh added 6 commits July 6, 2020 18:59

Merge remote-tracking branch 'upstream' into enable-gcc-tests

9a877ff

Signed-off-by: Dmitri Dolguikh <[email protected]>

Merge remote-tracking branch 'upstream' into enable-gcc-tests

5012387

Signed-off-by: Dmitri Dolguikh <[email protected]>

Merge remote-tracking branch 'upstream' into enable-gcc-tests

f93b055

Signed-off-by: Dmitri Dolguikh <[email protected]>

Fixed an issue in GCC_COMPILER macro definition

59cdc99

Signed-off-by: Dmitri Dolguikh <[email protected]>

Merge remote-tracking branch 'upstream' into enable-gcc-tests

c74a76c

Signed-off-by: Dmitri Dolguikh <[email protected]>

Fixed formatting

a4bdfcb

Signed-off-by: Dmitri Dolguikh <[email protected]>

lizan reviewed Jul 8, 2020

View reviewed changes

Added 'override' to MockGrpcMux methods implementing the interface

df0787e

Signed-off-by: Dmitri Dolguikh <[email protected]>

Dmitri Dolguikh added 2 commits July 8, 2020 17:52

Fixed syntax of const override mock methods

14c2ec3

Signed-off-by: Dmitri Dolguikh <[email protected]>

Merge remote-tracking branch 'upstream' into enable-gcc-tests

cc9eb9e

Signed-off-by: Dmitri Dolguikh <[email protected]>

Merge remote-tracking branch 'upstream' into enable-gcc-tests

9d164cb

Signed-off-by: Dmitri Dolguikh <[email protected]>

lizan approved these changes Jul 9, 2020

View reviewed changes

lizan merged commit f2306b3 into envoyproxy:master Jul 10, 2020

dmitri-d deleted the enable-gcc-tests branch July 10, 2020 19:29

scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020

Tests are now being executed during gcc builds (envoyproxy#10236)

8eff8f6

Signed-off-by: Dmitri Dolguikh <[email protected]> Signed-off-by: scheler <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests are now being executed during gcc builds #10236

Tests are now being executed during gcc builds #10236

dmitri-d commented Mar 3, 2020

lizan commented Mar 3, 2020

dmitri-d commented Mar 9, 2020

lizan commented Mar 12, 2020

azure-pipelines bot commented Mar 12, 2020

dmitri-d commented Mar 17, 2020 •

edited

Loading

stale bot commented Mar 24, 2020

dmitri-d commented Mar 24, 2020

lizan commented Mar 25, 2020

dmitri-d commented Mar 26, 2020

lizan commented Mar 26, 2020

dmitri-d commented Mar 30, 2020

lizan commented Mar 30, 2020

dmitri-d commented Mar 30, 2020

stale bot commented Apr 7, 2020

stale bot commented Apr 14, 2020

dmitri-d commented May 12, 2020

twghu commented Jun 26, 2020

stale bot commented Jul 3, 2020

lizan Jul 8, 2020

lizan Jul 8, 2020

dmitri-d Jul 8, 2020

lizan Jul 8, 2020

dmitri-d commented Jul 8, 2020

dmitri-d commented Jul 9, 2020

dmitri-d commented Jul 9, 2020

dmitri-d commented Jul 10, 2020

dmitri-d commented Jul 10, 2020

Tests are now being executed during gcc builds #10236

Tests are now being executed during gcc builds #10236

Conversation

dmitri-d commented Mar 3, 2020

lizan commented Mar 3, 2020

dmitri-d commented Mar 9, 2020

lizan commented Mar 12, 2020

azure-pipelines bot commented Mar 12, 2020

dmitri-d commented Mar 17, 2020 • edited Loading

stale bot commented Mar 24, 2020

dmitri-d commented Mar 24, 2020

lizan commented Mar 25, 2020

dmitri-d commented Mar 26, 2020

lizan commented Mar 26, 2020

dmitri-d commented Mar 30, 2020

lizan commented Mar 30, 2020

dmitri-d commented Mar 30, 2020

stale bot commented Apr 7, 2020

stale bot commented Apr 14, 2020

dmitri-d commented May 12, 2020

twghu commented Jun 26, 2020

stale bot commented Jul 3, 2020

lizan Jul 8, 2020

Choose a reason for hiding this comment

lizan Jul 8, 2020

Choose a reason for hiding this comment

dmitri-d Jul 8, 2020

Choose a reason for hiding this comment

lizan Jul 8, 2020

Choose a reason for hiding this comment

dmitri-d commented Jul 8, 2020

dmitri-d commented Jul 9, 2020

dmitri-d commented Jul 9, 2020

dmitri-d commented Jul 10, 2020

dmitri-d commented Jul 10, 2020

dmitri-d commented Mar 17, 2020 •

edited

Loading