listener filters: use new style names #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the well-known-names of the built-in listener filters to use the same names as the extension build system. Risk Level: low, previous name is still accepted Testing: existing tests + deprecated tests for old names Docs Changes: updated names Release Notes: updated Deprecated: old names are logged as deprecated Signed-off-by: Stephan Zuercher <[email protected]>
zuercher
requested review from
htuch,
lizan,
PiotrSikora and
snowp
as code owners
mattklein123
requested changes
Feb 29, 2020
docs/root/index.rst
Outdated
| @@ -1,7 +1,7 @@ | |||
| Envoy documentation | |||
| ================================= | |||
|
|
|||
| .. ifconfig:: release_level in ('pre-release') | |||
| d.. ifconfig:: release_level in ('pre-release') | |||
Signed-off-by: Stephan Zuercher <[email protected]>
Signed-off-by: Stephan Zuercher <[email protected]>
mattklein123
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the well-known-names of the built-in listener filters
to use the same names as the extension build system.
Risk Level: low, previous name is still accepted
Testing: existing tests + deprecated tests for old names
Docs Changes: updated names
Release Notes: updated
Deprecated: old names are logged as deprecated
Signed-off-by: Stephan Zuercher [email protected]