-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected error on upgrade to v1.13.0. #9922
Comments
Is the excluded route failing? Or the non-excluded routes? That might help us narrow down the introduced bug. |
Hi, @mattklein123. It's the excluded route failing (that uses For the non-excluded routes works correctly. |
Yeah this sounds like a regression to me. cc @lizan @kyessenov @derekargueta for thoughts as all have worked in this area recently. |
Hi @lizan @kyessenov @derekargueta @mattklein123, |
@sp-manuel-jurado if you can provide that. It will be very useful. |
For sure, I try to prepare it during the day and provide it ASAP. |
Hi @dio sorry for the delay, If you want to run the tests in your local machine:
Results summary:
README.md: envoyproxy-envoy-issues-9922Related envoy issue: It runs some e2e tests against next envoy versions running in docker containers:
Ping gRPC service is used:
Notes:
Run e2e tests:Install dependencies: After that, run tests executing:
Envoy config used
Results
LogsTests:
All:
|
cc @Chuongv do you want to fix this? |
From what I understand, once encodeData with Though it is hard to tell since there is no actual integration test for this filter 😬 . It should be simple to verify by making a change and following the repro steps. |
Right. What I'm saying is for disabled path, |
Hi, If you want level log traces in e2e tests in this repo: https://github.com/sp-manuel-jurado/envoyproxy-envoy-issues-9922 I can enable them and share here the results. |
@sp-manuel-jurado thanks for the detailed e2e test. A fix posted as #11271. |
many thanks, @lizan |
Fixed a bug that in route disabled grpc_http1_reverse_bridge case, encodeTrailers may add an empty gRPC frame at the end of response body, which causes failure of gRPC client. Risk Level: Low Testing: integration test Docs Changes: N/A Release Notes: N/A Fixes #9922 Signed-off-by: Lizan Zhou <[email protected]>
Title: Unexpected error on upgrade to v1.13.0.
Description:
I suspect it can be related to "envoy.filters.http.grpc_http1_reverse_bridge" (but I'm not sure).
I need to enable this bridge for the rest of the routes and disable for "/rpc.PingService/" ping service route (
per_filter_config.envoy.filters.http.grpc_http1_reverse_bridge.disabled: true
).If I remove the
envoy.filters.http.grpc_http1_reverse_bridge
to test only "/rpc.PingService/" using v1.13.0 works properly.Do I have to add any change to the envoy config?
Do I forget anything?
Thanks in advance.
Repro steps:
Config:
Config working properly in v1.12.0.
The text was updated successfully, but these errors were encountered: