You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
source/server/server.cc:406:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
source/server/server.cc:418:46: note: Call to virtual function during construction
Runtime::LoaderSingleton::get().initialize(clusterManager());
The text was updated successfully, but these errors were encountered:
Yes this is legit clang-tidy error because virtual function invoked in constructor are bug-prone, (i.e. base class constructor cannot call virtual function overridden in derived class). Feel free to make clusterManager final in InstanceImpl.
Signed-off-by: Yuchen Dai [email protected]
Description:
Refactor InstanceImpl and remove the only derived test class of InstanceImpl
Mark entire Server::InstanceImpl as final to avoid accidentally invoke virtual function in InstanceImpl constructor.
Massage clang-tidy.
Fixes#8509
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai [email protected]
Description:
Refactor InstanceImpl and remove the only derived test class of InstanceImpl
Mark entire Server::InstanceImpl as final to avoid accidentally invoke virtual function in InstanceImpl constructor.
Massage clang-tidy.
Fixesenvoyproxy#8509
Signed-off-by: Yuchen Dai <[email protected]>
Create this issue to avoid involving too many things in a single PR.
Not end of the world since the inheritance is only used by test but no production. And tests are passing.
Repro steps:
#8485
#4863
The text was updated successfully, but these errors were encountered: