Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow fallback to default filter chain when listener filters timeout #7195

Closed
lizan opened this issue Jun 6, 2019 · 4 comments · Fixed by #7859
Closed

allow fallback to default filter chain when listener filters timeout #7195

lizan opened this issue Jun 6, 2019 · 4 comments · Fixed by #7859
Assignees
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@lizan
Copy link
Member

lizan commented Jun 6, 2019

Description:
Currently the timeout for listener filters behaves:

The timeout to wait for all listener filters to complete operation. If the timeout is reached, the accepted socket is closed without a connection being created. Specify 0 to disable the timeout

There should be a configurable option allow this to fallback to a default filter chain (the filter chain with empty filter chain match) when they timeout.

@lizan
Copy link
Member Author

lizan commented Jun 6, 2019

cc @rshriram @louiscryan

@lizan lizan added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Jun 6, 2019
@incfly
Copy link
Contributor

incfly commented Jun 21, 2019

Mind providing more context on use case why listener filter can time out? One thing I've experienced, not sure if it's scoped in this FR, is the tls_inspector can sometimes get stuck if the tls handshake is initiated in from server side, for that very reason, the Istio PERMISSIVE mode does not work for MySQL.

@rshriram
Copy link
Member

thats what @lizan is talking about.. For mysql,, the filter will wait for data from client forever.. Instead, it should timeout and fallback to some default filter chain.

@incfly
Copy link
Contributor

incfly commented Jun 21, 2019

Sounds great, this can benefit Istio directly.

If Envoy folks also think this generic useful feature, I'm interested in helping on this one (very closed to wrap a PR for another FR, #7111).

@lizan lizan self-assigned this Aug 8, 2019
@lizan lizan removed the help wanted Needs help! label Aug 8, 2019
lizan added a commit that referenced this issue Aug 9, 2019
Description:
Add an option to continue on listener filters timeout.

Risk Level: Med (mostly guarded by config)
Testing: unittest
Docs Changes: Added
Release Notes: Added
Fixes #7195

Signed-off-by: Lizan Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
3 participants