Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_restart_features_quic_handle_certs_with_shared_tls_code deprecation #36612

Closed
alyssawilk opened this issue Oct 15, 2024 · 0 comments · Fixed by #36772
Closed

envoy_restart_features_quic_handle_certs_with_shared_tls_code deprecation #36612

alyssawilk opened this issue Oct 15, 2024 · 0 comments · Fixed by #36772
Assignees
@ggreenway
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #32260 (quic: support cert selection by SNI, non-PEM formats) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 15, 2024
ggreenway added a commit to ggreenway/envoy that referenced this issue Oct 22, 2024
@ggreenway
quic: remove runtime guard and code for legacy cert handling
ee2e0f2 
Fixes envoyproxy#36612

Signed-off-by: Greg Greenway <[email protected]>
@ggreenway ggreenway mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggreenway ggreenway

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quic: remove runtime guard and code for legacy cert handling ggreenway/envoy
2 participants
@ggreenway @alyssawilk