Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_ssl_transport_failure_reason_format deprecation #35375

Closed
alyssawilk opened this issue Jul 23, 2024 · 0 comments
Closed

envoy_reloadable_features_ssl_transport_failure_reason_format deprecation #35375

alyssawilk opened this issue Jul 23, 2024 · 0 comments
Assignees
@botengyao
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #29875 (tls: modify ssl failure reason format) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jul 23, 2024
@botengyao botengyao mentioned this issue Jul 23, 2024
Merged
alyssawilk pushed a commit that referenced this issue Jul 23, 2024
@botengyao
tls: remove runtime guard ssl_transport_failure_reason_format (#35389)
e5fc7ec 
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:#35375

---------

Signed-off-by: Boteng Yao <[email protected]>
martinduke pushed a commit to martinduke/envoy that referenced this issue Aug 8, 2024
@botengyao @martinduke
tls: remove runtime guard ssl_transport_failure_reason_format (envo…
b47ef23 
…yproxy#35389)

Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:envoyproxy#35375

---------

Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this issue Aug 20, 2024
@botengyao @asingh-g
tls: remove runtime guard ssl_transport_failure_reason_format (envo…
a0e61de 
…yproxy#35389)

Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:envoyproxy#35375

---------

Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: asingh-g <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@botengyao botengyao

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alyssawilk @botengyao