Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy_reloadable_features_abort_filter_chain_on_stream_reset deprecation #35364

Closed
alyssawilk opened this issue Jul 23, 2024 · 0 comments · Fixed by #35405
Closed

envoy_reloadable_features_abort_filter_chain_on_stream_reset deprecation #35364

alyssawilk opened this issue Jul 23, 2024 · 0 comments · Fixed by #35405
Assignees
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #31775 (http: abort filter chain after reset stream was called) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.

@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jul 23, 2024
alyssawilk pushed a commit that referenced this issue Jul 24, 2024
…hain_on_stream_reset (#35405)

Commit Message: runtime: remove runtime flag
envoy.reloadable_features.abort_filter_chain_on_stream_reset
Description: 

To close #35364

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.

Signed-off-by: wbpcode <[email protected]>
martinduke pushed a commit to martinduke/envoy that referenced this issue Aug 8, 2024
…hain_on_stream_reset (envoyproxy#35405)

Commit Message: runtime: remove runtime flag
envoy.reloadable_features.abort_filter_chain_on_stream_reset
Description:

To close envoyproxy#35364

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.

Signed-off-by: wbpcode <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this issue Aug 20, 2024
…hain_on_stream_reset (envoyproxy#35405)

Commit Message: runtime: remove runtime flag
envoy.reloadable_features.abort_filter_chain_on_stream_reset
Description:

To close envoyproxy#35364

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.

Signed-off-by: wbpcode <[email protected]>
Signed-off-by: asingh-g <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
2 participants