Stats: RDS_ROUTE_CONFIG tag extraction

[kb000]

Title: Some route_config_names fail tag extraction

Description:
RDS routes with legal names not expected by the <ROUTE_CONFIG_NAME> re2 regex fail tag extraction into prometheus stats.
The use case I've run across includes / in route names, though from the xds spec I'm not sure there's actually any restriction on route naming. You can configure the HttpConnectionManager with "route_config": {"name": "🚀🙏:)", ... } and it's accepted.

Repro steps:
Configure an xds route named ingressgateway/api-tess-io-1-gw-443 on http connection manager ingress_http

Admin and Stats Output:
/stats:

http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.config_reload: 1
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.config_reload_time_ms: 1710814314824
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.control_plane.connected_state: 1
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.control_plane.pending_requests: 0
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.control_plane.rate_limit_enforced: 0
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.init_fetch_timeout: 0
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.update_attempt: 13
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.update_empty: 0
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.update_failure: 0
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.update_rejected: 0
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.update_success: 12
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.update_time: 1710851152272
http.ingress_http.rds.ingressgateway/api-tess-io-1-gw-443.version: 17181926294437511708

/stats/prometheus:

# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_config_reload counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_config_reload{envoy_http_conn_manager_prefix="ingress_http"} 1
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_control_plane_rate_limit_enforced counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_control_plane_rate_limit_enforced{envoy_http_conn_manager_prefix="ingress_http"} 0
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_init_fetch_timeout counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_init_fetch_timeout{envoy_http_conn_manager_prefix="ingress_http"} 0
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_attempt counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_attempt{envoy_http_conn_manager_prefix="ingress_http"} 13
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_empty counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_empty{envoy_http_conn_manager_prefix="ingress_http"} 0
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_failure counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_failure{envoy_http_conn_manager_prefix="ingress_http"} 0
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_rejected counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_rejected{envoy_http_conn_manager_prefix="ingress_http"} 0
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_success counter
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_success{envoy_http_conn_manager_prefix="ingress_http"} 12
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_config_reload_time_ms gauge
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_config_reload_time_ms{envoy_http_conn_manager_prefix="ingress_http"} 1710814314824
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_control_plane_connected_state gauge
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_control_plane_connected_state{envoy_http_conn_manager_prefix="ingress_http"} 1
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_control_plane_pending_requests gauge
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_control_plane_pending_requests{envoy_http_conn_manager_prefix="ingress_http"} 0
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_time gauge
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_update_time{envoy_http_conn_manager_prefix="ingress_http"} 1710851152272
# TYPE envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_version gauge
envoy_http_rds_ingressgateway_api_tess_io_1_gw_443_version{envoy_http_conn_manager_prefix="ingress_http"} 17181926294437511708

Prometheus stats should be:

envoy_http_rds_config_reload{envoy_http_conn_manager_prefix="ingress_http",envoy_rds_route_config="ingressgateway/api-tess-io-1-gw-443"} 1
etc.

[kb000]

Looks to be introduced by #14519

[htuch]

@rojkov @jmarantz

[kb000]

If we decide what the behavior should be (how much to allow in this regex), I can make the change.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[kb000]

Ok I'll make a PR and we can talk about what characters to allow in comments.