Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract username from basic auth http filter #32419

Closed
fgouteroux opened this issue Feb 15, 2024 · 5 comments
Closed

Extract username from basic auth http filter #32419

fgouteroux opened this issue Feb 15, 2024 · 5 comments
Assignees
Labels
area/http_filter enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@fgouteroux
Copy link

Hi,

I would ask for an update of the basic auth http filter (#30079) to extract the username in a header or metadata.

The use case is the following, after user auth success I need to add the username in the request header that will be used by the application after. Ideally if we can choose the header name, it will be perfect.

Maybe something like:

users:
  inline_string: |-
      user1:{SHA}hashed_user1_password
      user2:{SHA}hashed_user2_password
  set_username_header: X-Scope-OrgID

cc @zhaohuabing

@fgouteroux fgouteroux added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 15, 2024
@kyessenov kyessenov added area/http_filter and removed triage Issue requires triage labels Feb 15, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 17, 2024
Copy link

zhaohuabing is not allowed to assign users.

🐱

Caused by: a #32419 (comment) was created by @zhaohuabing.

see: more, trace.

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Mar 17, 2024
@zhaohuabing
Copy link
Member

Hello, could you please assign this issue to me?

htuch pushed a commit that referenced this issue Mar 28, 2024
Related to #32419

Risk level: Low
Testing: Unit/integration tests.

Signed-off-by: Huabing Zhao <[email protected]>
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 26, 2024
alyssawilk pushed a commit to alyssawilk/envoy that referenced this issue Apr 29, 2024
Related to envoyproxy#32419

Risk level: Low
Testing: Unit/integration tests.

Signed-off-by: Huabing Zhao <[email protected]>
Copy link

github-actions bot commented May 3, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http_filter enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants