Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy v1.29.0 build fails on Mac OS #31932

Closed
lukidzi opened this issue Jan 22, 2024 · 7 comments · Fixed by #32148
Closed

Envoy v1.29.0 build fails on Mac OS #31932

lukidzi opened this issue Jan 22, 2024 · 7 comments · Fixed by #32148

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Jan 22, 2024

Title: Envoy v1.29.0 build fails on Mac OS

Description:
When I am building Envoy v1.29.0 on MacOS 12.7.1 with clang 14.0.0 I noticed an error

ec2-user@Mac-mini envoy-builds % gcc --version
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Envoy build error

Undefined symbols for architecture x86_64:
  "cel::interop_internal::ProtoStructValueToMessageWrapper(cel::Value const&)", referenced from:
      cel::interop_internal::ToLegacyValue(google::protobuf::Arena*, cel::Handle<cel::Value> const&, bool) in libinterop.a(interop.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //contrib/exe:envoy-static failed to build
INFO: Elapsed time: 136.522s, Critical Path: 46.32s

I've tried both conrtib and not contrib build but I have the same issue.

Repro steps:

  1. Use mac 12.7.1 or 11.7.10 (on aws ami-06bf601fad285cc69 or ami-0da052d2225304b8f)
  2. Setup CI tools
  3. run bazel build -c opt envoy
  4. Notice error at the last step
Undefined symbols for architecture x86_64:
  "cel::interop_internal::ProtoStructValueToMessageWrapper(cel::Value const&)", referenced from:
      cel::interop_internal::ToLegacyValue(google::protobuf::Arena*, cel::Handle<cel::Value> const&, bool) in libinterop.a(interop.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //contrib/exe:envoy-static failed to build
INFO: Elapsed time: 136.522s, Critical Path: 46.32s

I've noticed that more people have the same issue Homebrew/homebrew-core#160068

@lukidzi lukidzi added bug triage Issue requires triage labels Jan 22, 2024
@phlax
Copy link
Member

phlax commented Jan 22, 2024

cc @kyessenov @moderation

@phlax phlax added area/build area/macos and removed triage Issue requires triage labels Jan 22, 2024
@moderation
Copy link
Contributor

I think it was likely I was just the first to hit this. If this is WONTFIX, we should update documentation to say building on MacOS no longer possible after relevant commit. Wondering how many people are running MacOS instances in the cloud.

@phlax
Copy link
Member

phlax commented Jan 22, 2024

i think it should be resolvable one way or other

to clarify - macos does build, as we are building/testing in ci still (macos12 github runners)

i believe the constraint is to use the correct versions of compiler - it may be that our ci just builds less and excludes cel - not sure and no way to test

the setup for the macos12 images is here https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md - i dont see any setup for this on our end (here https://github.com/envoyproxy/envoy/blob/main/ci/mac_ci_setup.sh) so assume that we are just using whatever is default in the macos12 image

update documentation to say building on MacOS no longer possible after relevant commit

perhaps we can (figure out and) specify what does work

@ggreenway
Copy link
Contributor

git bisect says this is caused by bd1dca3

@ggreenway
Copy link
Contributor

@phlax that's a fairly old version of macOS for CI. Is there a runner based on macOS version 14 we can use?

@moderation
Copy link
Contributor

Related #31456 (comment)

@ggreenway
Copy link
Contributor

Related #31456 (comment)

Thanks for the extra context; I hadn't seen that.

ggreenway added a commit to ggreenway/envoy that referenced this issue Feb 8, 2024
Attempting to catch build breaks similar to those in envoyproxy#31932

Signed-off-by: Greg Greenway <[email protected]>
ggreenway added a commit that referenced this issue Feb 8, 2024
Attempting to catch build breaks similar to those in #31932

Signed-off-by: Greg Greenway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants