Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash in admin /config_dump #3141

Closed
ggreenway opened this issue Apr 19, 2018 · 1 comment
Closed

crash in admin /config_dump #3141

ggreenway opened this issue Apr 19, 2018 · 1 comment
Assignees
@mattklein123
Labels
bug
Milestone
1.7.0

Comments

@ggreenway
Copy link
Contributor

curl localhost:8001/config_dump

Backtrace:

[2018-04-19 16:47:14.189][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] Caught Segmentation fault: 11, suspect faulting address 0x0
[2018-04-19 16:47:14.196][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:87] Backtrace obj<envoy-static> thr<0>:
[2018-04-19 16:47:14.196][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:99] thr<0> obj<envoy-static                        0x000000010bc36a36 _ZN5Envoy6Router30RouteConfigProviderManagerImpl29getStaticRouteConfigProvidersEv>
[2018-04-19 16:47:14.196][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #0 0x10bc36a36: 
[2018-04-19 16:47:14.196][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:99] thr<0> obj<envoy-static>
[2018-04-19 16:47:14.210][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #1 0x10bc3a386: Envoy::Router::RouteConfigProviderManagerImpl::dumpRouteConfigs() + 1222
[2018-04-19 16:47:14.210][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #2 0x10bc4ac8e: Envoy::Router::RouteConfigProviderManagerImpl::RouteConfigProviderManagerImpl(Envoy::Runtime::Loader&, Envoy::Event::Dispatcher&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::ThreadLocal::SlotAllocator&, Envoy::Server::Admin&)::$_3::operator()() const + 30
[2018-04-19 16:47:14.210][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #3 0x10bc4ac63: std::__1::__invoke_void_return_wrapper<std::__1::unique_ptr<google::protobuf::Message, std::__1::default_delete<google::protobuf::Message> > >::__call<Envoy::Router::RouteConfigProviderManagerImpl::RouteConfigProviderManagerImpl(Envoy::Runtime::Loader&, Envoy::Event::Dispatcher&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::ThreadLocal::SlotAllocator&, Envoy::Server::Admin&)::$_3&>(std::__1::unique_ptr<google::protobuf::Message, std::__1::default_delete<google::protobuf::Message> >, Envoy::Router::RouteConfigProviderManagerImpl::RouteConfigProviderManagerImpl(Envoy::Runtime::Loader&, Envoy::Event::Dispatcher&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::ThreadLocal::SlotAllocator&, Envoy::Server::Admin&)::$_3&&&) + 51
[2018-04-19 16:47:14.264][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #4 0x10bc4ab1f: std::__1::__function::__func<Envoy::Router::RouteConfigProviderManagerImpl::RouteConfigProviderManagerImpl(Envoy::Runtime::Loader&, Envoy::Event::Dispatcher&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::ThreadLocal::SlotAllocator&, Envoy::Server::Admin&)::$_3, std::__1::allocator<Envoy::Router::RouteConfigProviderManagerImpl::RouteConfigProviderManagerImpl(Envoy::Runtime::Loader&, Envoy::Event::Dispatcher&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::ThreadLocal::SlotAllocator&, Envoy::Server::Admin&)::$_3>, std::__1::unique_ptr<google::protobuf::Message, std::__1::default_delete<google::protobuf::Message> > ()>::operator()() + 47
[2018-04-19 16:47:14.308][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #5 0x10c06a1c9: std::__1::function<std::__1::unique_ptr<google::protobuf::Message, std::__1::default_delete<google::protobuf::Message> > ()>::operator()() const + 137
[2018-04-19 16:47:14.308][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #6 0x10c069bb2: Envoy::Server::AdminImpl::handlerConfigDump(absl::string_view, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&) const + 898
[2018-04-19 16:47:14.364][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #7 0x10c0a3747: Envoy::Server::AdminImpl::AdminImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Server::Instance&, std::__1::unique_ptr<Envoy::Stats::Scope, std::__1::default_delete<Envoy::Stats::Scope> >&&)::$_4::operator()(absl::string_view, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&) const + 71
[2018-04-19 16:47:14.364][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #8 0x10c0a36f2: std::__1::__invoke_void_return_wrapper<Envoy::Http::Code>::__call<Envoy::Server::AdminImpl::AdminImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Server::Instance&, std::__1::unique_ptr<Envoy::Stats::Scope, std::__1::default_delete<Envoy::Stats::Scope> >&&)::$_4&, absl::string_view, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&>(Envoy::Http::Code, Envoy::Server::AdminImpl::AdminImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Server::Instance&, std::__1::unique_ptr<Envoy::Stats::Scope, std::__1::default_delete<Envoy::Stats::Scope> >&&)::$_4&&&, absl::string_view&&, Envoy::Http::HeaderMap&&&, Envoy::Buffer::Instance&&&) + 178
[2018-04-19 16:47:14.488][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #9 0x10c0a3588: std::__1::__function::__func<Envoy::Server::AdminImpl::AdminImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Server::Instance&, std::__1::unique_ptr<Envoy::Stats::Scope, std::__1::default_delete<Envoy::Stats::Scope> >&&)::$_4, std::__1::allocator<Envoy::Server::AdminImpl::AdminImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<Envoy::Network::Address::Instance const>, Envoy::Server::Instance&, std::__1::unique_ptr<Envoy::Stats::Scope, std::__1::default_delete<Envoy::Stats::Scope> >&&)::$_4>, Envoy::Http::Code (absl::string_view, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&)>::operator()(absl::string_view&&, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&) + 88
[2018-04-19 16:47:14.548][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #10 0x10c081e94: std::__1::function<Envoy::Http::Code (absl::string_view, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&)>::operator()(absl::string_view, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&) const + 196
[2018-04-19 16:47:14.615][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #11 0x10c07c6fa: Envoy::Server::AdminImpl::runCallback(absl::string_view, Envoy::Http::HeaderMap const&, Envoy::Http::HeaderMap&, Envoy::Buffer::Instance&) + 1066
[2018-04-19 16:47:14.615][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #12 0x10c064525: Envoy::Server::AdminFilter::onComplete() + 1013
[2018-04-19 16:47:14.616][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #13 0x10c064119: Envoy::Server::AdminFilter::decodeHeaders(Envoy::Http::HeaderMap&, bool) + 57
[2018-04-19 16:47:14.616][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #14 0x10c0e6779: Envoy::Http::ConnectionManagerImpl::ActiveStream::decodeHeaders(Envoy::Http::ConnectionManagerImpl::ActiveStreamDecoderFilter*, Envoy::Http::HeaderMap&, bool) + 1657
[2018-04-19 16:47:14.685][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #15 0x10c0e3cca: Envoy::Http::ConnectionManagerImpl::ActiveStream::decodeHeaders(std::__1::unique_ptr<Envoy::Http::HeaderMap, std::__1::default_delete<Envoy::Http::HeaderMap> >&&, bool) + 11130
[2018-04-19 16:47:14.685][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #16 0x10c0e711a: non-virtual thunk to Envoy::Http::ConnectionManagerImpl::ActiveStream::decodeHeaders(std::__1::unique_ptr<Envoy::Http::HeaderMap, std::__1::default_delete<Envoy::Http::HeaderMap> >&&, bool) + 58
[2018-04-19 16:47:14.685][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #17 0x10c1bd412: Envoy::Http::Http1::ServerConnectionImpl::onMessageComplete() + 418
[2018-04-19 16:47:14.757][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #18 0x10c1bd5a8: non-virtual thunk to Envoy::Http::Http1::ServerConnectionImpl::onMessageComplete() + 24
[2018-04-19 16:47:14.757][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #19 0x10c1c1400: Envoy::Http::Http1::ConnectionImpl::$_7::operator()(http_parser*) const + 32
[2018-04-19 16:47:14.757][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #20 0x10c1c13d7: Envoy::Http::Http1::ConnectionImpl::$_7::__invoke(http_parser*) + 23
[2018-04-19 16:47:14.757][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #21 0x10c1cebd3: http_parser_execute + 19235
[2018-04-19 16:47:14.828][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #22 0x10c1ba905: Envoy::Http::Http1::ConnectionImpl::dispatchSlice(char const*, unsigned long) + 101
[2018-04-19 16:47:14.828][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #23 0x10c1ba7c5: Envoy::Http::Http1::ConnectionImpl::dispatch(Envoy::Buffer::Instance&) + 501
[2018-04-19 16:47:14.829][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #24 0x10c1bac66: virtual thunk to Envoy::Http::Http1::ConnectionImpl::dispatch(Envoy::Buffer::Instance&) + 38
[2018-04-19 16:47:14.829][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #25 0x10c0daf8b: Envoy::Http::ConnectionManagerImpl::onData(Envoy::Buffer::Instance&, bool) + 1355
[2018-04-19 16:47:14.902][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #26 0x10bbf4ce8: Envoy::Network::FilterManagerImpl::onContinueReading(Envoy::Network::FilterManagerImpl::ActiveReadFilter*) + 1496
[2018-04-19 16:47:14.902][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #27 0x10bbf4eb1: Envoy::Network::FilterManagerImpl::onRead() + 177
[2018-04-19 16:47:14.902][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #28 0x10bbe33cf: Envoy::Network::ConnectionImpl::onRead(unsigned long long) + 239
[2018-04-19 16:47:14.902][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #29 0x10bbe6405: Envoy::Network::ConnectionImpl::onReadReady() + 405
[2018-04-19 16:47:14.971][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #30 0x10bbe6225: Envoy::Network::ConnectionImpl::onFileEvent(unsigned int) + 789
[2018-04-19 16:47:14.971][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #31 0x10bbee08d: Envoy::Network::ConnectionImpl::ConnectionImpl(Envoy::Event::Dispatcher&, std::__1::unique_ptr<Envoy::Network::ConnectionSocket, std::__1::default_delete<Envoy::Network::ConnectionSocket> >&&, std::__1::unique_ptr<Envoy::Network::TransportSocket, std::__1::default_delete<Envoy::Network::TransportSocket> >&&, bool)::$_2::operator()(unsigned int) const + 29
[2018-04-19 16:47:14.971][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #32 0x10bbee05e: _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN5Envoy7Network14ConnectionImplC1ERNS3_5Event10DispatcherEONS_10unique_ptrINS4_16ConnectionSocketENS_14default_deleteISA_EEEEONS9_INS4_15TransportSocketENSB_ISF_EEEEbE3$_2jEEEvDpOT_ + 78
[2018-04-19 16:47:15.042][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #33 0x10bbedf58: std::__1::__function::__func<Envoy::Network::ConnectionImpl::ConnectionImpl(Envoy::Event::Dispatcher&, std::__1::unique_ptr<Envoy::Network::ConnectionSocket, std::__1::default_delete<Envoy::Network::ConnectionSocket> >&&, std::__1::unique_ptr<Envoy::Network::TransportSocket, std::__1::default_delete<Envoy::Network::TransportSocket> >&&, bool)::$_2, std::__1::allocator<Envoy::Network::ConnectionImpl::ConnectionImpl(Envoy::Event::Dispatcher&, std::__1::unique_ptr<Envoy::Network::ConnectionSocket, std::__1::default_delete<Envoy::Network::ConnectionSocket> >&&, std::__1::unique_ptr<Envoy::Network::TransportSocket, std::__1::default_delete<Envoy::Network::TransportSocket> >&&, bool)::$_2>, void (unsigned int)>::operator()(unsigned int&&) + 56
[2018-04-19 16:47:15.111][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #34 0x10bbcb717: std::__1::function<void (unsigned int)>::operator()(unsigned int) const + 151
[2018-04-19 16:47:15.111][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #35 0x10bbcb66c: Envoy::Event::FileEventImpl::assignEvents(unsigned int)::$_0::operator()(int, short, void*) const + 236
[2018-04-19 16:47:15.111][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #36 0x10bbcb577: Envoy::Event::FileEventImpl::assignEvents(unsigned int)::$_0::__invoke(int, short, void*) + 55
[2018-04-19 16:47:15.180][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #37 0x10c5a5cba: event_process_active_single_queue + 1450
[2018-04-19 16:47:15.180][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #38 0x10c5a288d: event_base_loop + 1741
[2018-04-19 16:47:15.180][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #39 0x10bbc3961: Envoy::Event::DispatcherImpl::run(Envoy::Event::Dispatcher::RunType) + 97
[2018-04-19 16:47:15.180][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #40 0x10bb01eed: Envoy::Server::InstanceImpl::run() + 813
[2018-04-19 16:47:15.180][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #41 0x10b46b716: Envoy::MainCommonBase::run() + 150
[2018-04-19 16:47:15.252][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:105] thr<0> #42 0x10b43b61b: Envoy::MainCommon::run() + 27
[2018-04-19 16:47:15.252][5119424][critical][backtrace] bazel-out/darwin-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:110] end backtrace thread 0

Config:

{
  "listeners": [
    {
      "address": "tcp://0.0.0.0:8000",
      "filters": [
        {
          "type": "read",
          "name": "http_connection_manager",
          "config": {
            "codec_type": "auto",
            "stat_prefix": "whatever",
            "route_config": {
              "virtual_hosts": [
              ]
            },
            "filters": [
              {
                "type": "decoder",
                "name": "router",
                "config": {}
              }
            ]
          }
        }
      ]
    }
  ],
  "admin": {
    "access_log_path": "/dev/null",
    "address": "tcp://0.0.0.0:8001"
  },
  "cluster_manager": {
    "clusters": [

    ]
  }
}
@ggreenway ggreenway added the bug label Apr 19, 2018
@mattklein123 mattklein123 self-assigned this Apr 19, 2018
@mattklein123 mattklein123 added this to the 1.7.0 milestone Apr 19, 2018
@mattklein123
Copy link
Member

I already have this fixed as part of finishing up config_dump. Will post PR in next couple of days.

mattklein123 added a commit that referenced this issue Apr 24, 2018
@mattklein123
admin/xDS: prepare for full /config_dump and version support
df81052 
This change does several things:
1) Clarifies how we handle xDS version_info in responses and sets us up
   for both top-level/transactional versions as well as per-resource
   versions in the future.
2) Moves the config_dump admin endpoint to the v2alpha namespace so that
   we can iterate on it in the future.
3) Fills out the config dump proto for the remaining resource types.
   These are not implemented but are here to force a discussion about
   how we want to handle versions moving forward.
4) Fixes RDS static config dump to actually work and add better tests.
5) Wire up version for the RDS config dump on a per-resource basis.

Once we agree on the general version semantics I will be following up
with dump capability of the remaining resource types.

Part of #2421
Part of #2172
Fixes #3141

Signed-off-by: Matt Klein <[email protected]>
@mattklein123 mattklein123 mentioned this issue Apr 24, 2018
Merged
mattklein123 added a commit that referenced this issue May 8, 2018
@mattklein123
admin/xDS: prepare for full /config_dump and version support (#3199)
ada7587 
This change does several things:
1) Clarifies how we handle xDS version_info in responses and sets us up
   for both top-level/transactional versions as well as per-resource
   versions in the future.
2) Moves the config_dump admin endpoint to the v2alpha namespace so that
   we can iterate on it in the future.
3) Fills out the config dump proto for the remaining resource types.
   These are not implemented but are here to force a discussion about
   how we want to handle versions moving forward.
4) Fixes RDS static config dump to actually work and add better tests.
5) Wire up version for the RDS config dump on a per-resource basis.

Once we agree on the general version semantics I will be following up
with dump capability of the remaining resource types.

Part of #2421
Part of #2172
Fixes #3141

Signed-off-by: Matt Klein <[email protected]>
mattklein123 pushed a commit to envoyproxy/data-plane-api that referenced this issue May 8, 2018
admin/xDS: prepare for full /config_dump and version support (#3199)
fcd3ca7 
This change does several things:
1) Clarifies how we handle xDS version_info in responses and sets us up
   for both top-level/transactional versions as well as per-resource
   versions in the future.
2) Moves the config_dump admin endpoint to the v2alpha namespace so that
   we can iterate on it in the future.
3) Fills out the config dump proto for the remaining resource types.
   These are not implemented but are here to force a discussion about
   how we want to handle versions moving forward.
4) Fixes RDS static config dump to actually work and add better tests.
5) Wire up version for the RDS config dump on a per-resource basis.

Once we agree on the general version semantics I will be following up
with dump capability of the remaining resource types.

Part of envoyproxy/envoy#2421
Part of envoyproxy/envoy#2172
Fixes envoyproxy/envoy#3141

Signed-off-by: Matt Klein <[email protected]>

Mirrored from https://github.com/envoyproxy/envoy @ ada758739907628b50079b9adfccf5481ec9fc5f
@mattklein123 mattklein123 mentioned this issue May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattklein123 mattklein123

Labels
bug
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
2 participants
@mattklein123 @ggreenway