Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use std::steady_clock for intervals #312

Closed
mattklein123 opened this issue Jan 2, 2017 · 2 comments · Fixed by #748
Closed

use std::steady_clock for intervals #312

mattklein123 opened this issue Jan 2, 2017 · 2 comments · Fixed by #748
Assignees
@danielhochman
Labels
bug
Milestone
1.3.0

Comments

@mattklein123
Copy link
Member

The leap second brought to my attention that we are incorrectly using system_clock for computing time intervals when we should be using steady_clock.

http://en.cppreference.com/w/cpp/chrono/steady_clock
@mattklein123 mattklein123 added this to the 1.2.0 milestone Jan 2, 2017
@mattklein123 mattklein123 modified the milestones: 1.2.0, 1.3.0 Feb 11, 2017
@mattklein123 mattklein123 assigned danielhochman and unassigned junr03 Apr 3, 2017
@mattklein123
Copy link
Member Author

@danielhochman can you work on this as another warm up task.

@danielhochman
Copy link
Contributor

will do @mattklein123

@danielhochman danielhochman mentioned this issue Apr 13, 2017
Merged
4 tasks
rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
@sarvaniv
Use GetRequestPath in firebase rules service. (envoyproxy#312)
bae9313
rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
@istio-testing
Update_Dependencies (envoyproxy#312)
0383a54 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of mixerclient

This PR will be merged automatically once checks are successful.
```release-note
none
```
lizan added a commit to lizan/envoy that referenced this issue Nov 25, 2019
@lizan
wasm: fix V8 running under ASan without setup_clang. (envoyproxy#9036) (
9a228a0 
envoyproxy#312)

* wasm: fix V8 running under ASan without setup_clang.

Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
@rnburn rnburn mentioned this issue Jan 21, 2020
Merged
howardjohn pushed a commit to howardjohn/envoy that referenced this issue Apr 16, 2021
@bianpengyuan @tonya11en
@Shikugawa @cpakulski
Cherry-pick fix for greenpig (envoyproxy#312)
3887a0c 
* http: Fixing empty metadata map handling (envoyproxy#230) envoyproxy#250

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <[email protected]>

* grpc: fix grpc-timeout integer overflow (envoyproxy#255)

Fixes CVE-2021-28682, a remotely exploitable integer overflow.

Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Tony Allen <[email protected]>

* ssl: fix crash when peer sends an SSL Alert with an unknown code (envoyproxy#259)

Fixes CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code)

Signed-off-by: Shikugawa <[email protected]>
Co-authored-by: Christoph Pakulski <[email protected]>
Signed-off-by: Tony Allen <[email protected]>

Co-authored-by: Tony Allen <[email protected]>
Co-authored-by: Rei Shimizu <[email protected]>
Co-authored-by: Christoph Pakulski <[email protected]>
jpsim pushed a commit that referenced this issue Nov 28, 2022
@rebello95 @jpsim
ios: finish bridging between ObjC/Swift (#312)
c36e286 
This PR ties together the upstream Objective-C/++ implementation with the Swift interfaces/bridging implementation. After this change, end-to-end calls from the native Swift library into the Envoy core should be supported.

- Implements the streaming and unary request methods
- Adds a simple `EnvoyStreamEmitter` which sends requests from Swift down into Objective-C
- Updates the header conversion functions and their tests to convert to the proper types (`[String: [String]]` versus `[String: String]`)
- Implements `ResponseHandler` as a class which provides a pass-through for setting Objective-C blocks directly from Swift for handling responses
- Adds a parser for status codes, as well as tests

envoyproxy/envoy-mobile#349 will use this interface with the Swift demo apps.

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@rebello95 @jpsim
ios: finish bridging between ObjC/Swift (#312)
0a3a614 
This PR ties together the upstream Objective-C/++ implementation with the Swift interfaces/bridging implementation. After this change, end-to-end calls from the native Swift library into the Envoy core should be supported.

- Implements the streaming and unary request methods
- Adds a simple `EnvoyStreamEmitter` which sends requests from Swift down into Objective-C
- Updates the header conversion functions and their tests to convert to the proper types (`[String: [String]]` versus `[String: String]`)
- Implements `ResponseHandler` as a class which provides a pass-through for setting Objective-C blocks directly from Swift for handling responses
- Adds a parser for status codes, as well as tests

envoyproxy/envoy-mobile#349 will use this interface with the Swift demo apps.

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielhochman danielhochman

Labels
bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Replace system time with monotonic time for calculating intervals envoyproxy/envoy
3 participants
@danielhochman @junr03 @mattklein123