Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecds: add support for listener filters #20049

Closed
yanjunxiang-google opened this issue Feb 18, 2022 · 4 comments
Closed

ecds: add support for listener filters #20049

yanjunxiang-google opened this issue Feb 18, 2022 · 4 comments
Assignees
Labels
area/listener enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@yanjunxiang-google
Copy link
Contributor

yanjunxiang-google commented Feb 18, 2022

Title: ecds: add support for listener filters

Description:
ECDS support for HTTP filters are added by PR: #11826.
ECDS support for network filters are tracked by issue : #14696

This issue is to track the ECDS support for listener filters.

Task list:

  1. API change is here: Add API definition for ECDS listerner filter support #20050
  2. Further abstraction ECDS config discovery header file to make it extendable for other filters like lisenter ECDS filter: Abstraction ECDS config discovery header file to make it extendable #20445

The reason for this change is that prior to #20445, the two methods in class DynamicFilterConfigProviderImpl is tied into HTTP listener only:
validateMessage()
instantiateFilterFactory().

Thus #20445 is to abstract them out thus the logic can be implemented in filter type specific class.

  1. Create a class ListenerFilterConfigProviderImpl that implements FilterConfigProviderManagerImpl
    The PR for this work is: Listener ECDS: Adding config provider manager implemantion for listener filter #20560

  2. Adding a testing listener filter for unit and integration test(initially it's using tls_inspector ). The test listener filter added by test: creating a test listener filter and moving the xds test over to it #20571 can be leveraged once it is committed. Or writing something similar. (this work is done within in Listener ECDS: Adding config provider manager implemantion for listener filter #20560 )

TCP listener ECDS functionalities support :
5) Add A field with type ListenerFilterConfigProviderImpl in ListenerManagerImpl class for process listener filter.
6) Listener filter processing for the ECDS configuration.
7) Call listener filter factories when building the listener filter chain in createListenerFilterChain()

These are done by: #21133 Listener filter ECDS Support

  1. UDP listener ECDS functionalities support:
    This will be just changing the UDP listener counter part code as in above 5) 6) 7).
    i)also cleanup the parameter list in createDynamicFilterConfigProvider() (separate HTTP filter and Listener filter paramameters)
    ii) add a stats counter in the MissingConfigFilter installation case.

This is the PR:
#21606

  1. Adding release notes for listener ECDS.
    Adding docs/release notes for listener filter. #21646
@yanjunxiang-google yanjunxiang-google added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 18, 2022
yanjunxiang-google added a commit to yanjunxiang-google/envoy that referenced this issue Feb 18, 2022
@adisuissa adisuissa added area/listener and removed triage Issue requires triage labels Feb 23, 2022
@adisuissa
Copy link
Contributor

/assign @yanjunxiang-google as the person who is working on this at the moment.

@repokitteh-read-only
Copy link

🙀 Error while processing event:

evaluation error
error: function _rk_error error: path contains forbidden characters:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:135: in _main
  bootstrap:62: in _call
  bootstrap:15: in _call1
  github.com/repokitteh/modules/assign.star:18: in _assign
  github:395: in issue_check_assignee
  github:131: in call
Error: function _rk_error error: path contains forbidden characters
🐱

Caused by: a #20049 (comment) was created by @adisuissa.

see: more, trace.

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 9, 2022
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/listener enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants