-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecds: add support for listener filters #20049
Comments
Signed-off-by: Yanjun Xiang <[email protected]>
/assign @yanjunxiang-google as the person who is working on this at the moment. |
🙀 Error while processing event:
|
Signed-off-by: Yanjun Xiang <[email protected]>
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
Title: ecds: add support for listener filters
Description:
ECDS support for HTTP filters are added by PR: #11826.
ECDS support for network filters are tracked by issue : #14696
This issue is to track the ECDS support for listener filters.
Task list:
The reason for this change is that prior to #20445, the two methods in class DynamicFilterConfigProviderImpl is tied into HTTP listener only:
validateMessage()
instantiateFilterFactory().
Thus #20445 is to abstract them out thus the logic can be implemented in filter type specific class.
Create a class ListenerFilterConfigProviderImpl that implements FilterConfigProviderManagerImpl
The PR for this work is: Listener ECDS: Adding config provider manager implemantion for listener filter #20560
Adding a testing listener filter for unit and integration test(initially it's using tls_inspector ). The test listener filter added by test: creating a test listener filter and moving the xds test over to it #20571 can be leveraged once it is committed. Or writing something similar. (this work is done within in Listener ECDS: Adding config provider manager implemantion for listener filter #20560 )
TCP listener ECDS functionalities support :
5) Add A field with type ListenerFilterConfigProviderImpl in ListenerManagerImpl class for process listener filter.
6) Listener filter processing for the ECDS configuration.
7) Call listener filter factories when building the listener filter chain in createListenerFilterChain()
These are done by: #21133 Listener filter ECDS Support
This will be just changing the UDP listener counter part code as in above 5) 6) 7).
i)also cleanup the parameter list in createDynamicFilterConfigProvider() (separate HTTP filter and Listener filter paramameters)
ii) add a stats counter in the MissingConfigFilter installation case.
This is the PR:
#21606
Adding docs/release notes for listener filter. #21646
The text was updated successfully, but these errors were encountered: