Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newer release available com_github_nlohmann_json: v3.10.5 (current: v3.10.4) #19371

Closed
github-actions bot opened this issue Jan 3, 2022 · 4 comments · Fixed by #19384
Closed

Newer release available com_github_nlohmann_json: v3.10.5 (current: v3.10.4) #19371

github-actions bot opened this issue Jan 3, 2022 · 4 comments · Fixed by #19384
Assignees
@kfaseela
Labels
area/build dependencies Pull requests that update a dependency file no stalebot Disables stalebot from closing an issue

Comments

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Package Name: com_github_nlohmann_json
Current Version: v3.10.4@2021-10-16 12:49:30
Available Version: v3.10.5@2022-01-03 05:40:13
Upstream releases: https://github.com/nlohmann/json/releases
@github-actions github-actions bot added area/build dependencies Pull requests that update a dependency file no stalebot Disables stalebot from closing an issue labels Jan 3, 2022
@kfaseela kfaseela mentioned this issue Jan 4, 2022
Merged
@kfaseela
Copy link
Contributor

kfaseela commented Jan 4, 2022

@phlax you can assign this to me

@kfaseela
Copy link
Contributor

kfaseela commented Jan 4, 2022

/assign kfaseela

alyssawilk pushed a commit that referenced this issue Jan 12, 2022
@kfaseela
Update com_github_nlohmann_json: v3.10.5 (current: v3.10.4) (#19384)
1b9ba7f 
Signed-off-by: Faseela K [email protected]

Fixes #19371

Signed-off-by: Faseela K <[email protected]>
joshperry pushed a commit to joshperry/envoy that referenced this issue Feb 13, 2022
@kfaseela
Update com_github_nlohmann_json: v3.10.5 (current: v3.10.4) (envoypro…
996965c 
…xy#19384)

Signed-off-by: Faseela K [email protected]

Fixes envoyproxy#19371

Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Josh Perry <[email protected]>
@joancafom
Copy link

joancafom commented Mar 1, 2022 •
edited
Loading

Hi! I noticed that the latest Envoy Proxy release (1.21) does not include these changes. This wouldn't be so important if it wasn't for the fact that v3.10.4 of nlohmann_json accidentally broke compatibility with some GCC versions (see ref or ref). This ultimately leads to errors when building Envoy from source.

I see that these changes were landed onto master, but were not included as part of the latest release. Is there a reason for that? As of now, I can get by applying this patch to the release, but ideally, I'd prefer to have this on the next release 😀

@phlax
Copy link
Member

phlax commented Mar 1, 2022

cc @moderation @RyanTheOptimist

@moderation moderation mentioned this issue Mar 1, 2022
Merged
RyanTheOptimist pushed a commit to RyanTheOptimist/envoy that referenced this issue Mar 1, 2022
@kfaseela @RyanTheOptimist
Update com_github_nlohmann_json: v3.10.5 (current: v3.10.4) (envoypro…
082d0d6 
…xy#19384)

Signed-off-by: Faseela K [email protected]

Fixes envoyproxy#19371

Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Ryan Hamilton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfaseela kfaseela

Labels
area/build dependencies Pull requests that update a dependency file no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update com_github_nlohmann_json: v3.10.5 (current: v3.10.4) Nordix/envoy
3 participants
@phlax @kfaseela @joancafom