Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits deprecation #18437

Closed
alyssawilk opened this issue Oct 5, 2021 · 0 comments · Fixed by #18696
Closed

envoy.reloadable_features.grpc_json_transcoder_adhere_to_buffer_limits deprecation #18437

alyssawilk opened this issue Oct 5, 2021 · 0 comments · Fixed by #18696
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #14906 (grpc_json_transcoder: Adhere to decoder and encoder buffer limits) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
cc @nareddyt
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 5, 2021
@alyssawilk alyssawilk mentioned this issue Oct 20, 2021
Merged
lizan pushed a commit that referenced this issue Oct 27, 2021
@alyssawilk
runtime: removing envoy.reloadable_features.grpc_json_transcoder_adhe…
e29f8cd 
…re_to_buffer_limits (#18696)

Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Platform Specific Features: n/a
Fixes #18437

Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: removing envoy.reloadable_features.grpc_json_transcoder_adhe… alyssawilk/envoy
1 participant
@alyssawilk