Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gQUIC support from Envoy #16642

Closed
alyssawilk opened this issue May 24, 2021 · 3 comments · Fixed by #17465
Closed

remove gQUIC support from Envoy #16642

alyssawilk opened this issue May 24, 2021 · 3 comments · Fixed by #17465
Labels
no stalebot Disables stalebot from closing an issue quic-mvp Required for QUIC MVP tech debt

Comments

@alyssawilk
Copy link
Contributor

or at least make it clear it's going away fairly soon, and is not sticking around for the standard 1 year data plane SLO
@alyssawilk alyssawilk added tech debt no stalebot Disables stalebot from closing an issue quic-mvp Required for QUIC MVP labels May 24, 2021
@alyssawilk
Copy link
Contributor Author

We should also make sure h3-29 EoL is made clear, given it isn't expected to last a year.

@danzh2010 danzh2010 mentioned this issue Jul 23, 2021
Merged
@danzh2010
Copy link
Contributor

We should also make sure h3-29 EoL is made clear, given it isn't expected to last a year.

What's this about?

@DavidSchinazi
Copy link
Contributor

When QUIC goes GA in Envoy it will only support the RFC 9000 version (h3). All other versions (such as h3-29 or Google QUIC versions like h3-Q050) will be disabled by flags. This way we only commit to including h3 in the standard 1 year data plane SLO

alyssawilk pushed a commit that referenced this issue Jul 29, 2021
@danzh2010
quiche: remove google quic support (#17465)
110559f 
Commit Message: Remove support of Google QUIC. QUICHE supports both IETF QUIC and Google QUIC. Given that IETF QUIC has been launched by Google and Google QUIC will be deprecated soon, remove the support of Google QUIC will lower the future maintenance burden.

Risk Level: low
Testing: existing tests passed
Fixes #16642

Signed-off-by: Dan Zhang <[email protected]>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this issue Sep 30, 2021
@danzh2010
quiche: remove google quic support (envoyproxy#17465)
a35fd14 
Commit Message: Remove support of Google QUIC. QUICHE supports both IETF QUIC and Google QUIC. Given that IETF QUIC has been launched by Google and Google QUIC will be deprecated soon, remove the support of Google QUIC will lower the future maintenance burden.

Risk Level: low
Testing: existing tests passed
Fixes envoyproxy#16642

Signed-off-by: Dan Zhang <[email protected]>
@danzh2010 danzh2010 mentioned this issue Oct 21, 2021
Merged
RyanTheOptimist pushed a commit that referenced this issue Oct 22, 2021
@danzh2010
quiche: support draft 29 (#18647)
4b5b338 
Signed-off-by: Dan Zhang [email protected]

Commit Message: add back draft 29 support.

Risk Level: low
Testing: added unit test and integration test
Follow up on #16642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no stalebot Disables stalebot from closing an issue quic-mvp Required for QUIC MVP tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quiche: remove google quic support danzh2010/envoy
3 participants
@DavidSchinazi @alyssawilk @danzh2010