-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enforce pragma once in header file #15264
Labels
Comments
lambdai
added
enhancement
Feature requests. Not bugs or questions.
triage
Issue requires triage
labels
Mar 2, 2021
yeah, looks like it's mostly but not all test code. It'd definitely be worth adding to the fix format script IMO. |
alyssawilk
pushed a commit
that referenced
this issue
Mar 3, 2021
Commit Message: Add pragma once almost every header. Risk Level: LOW Testing: self-contained Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] Part of #15264 [Optional Deprecated:] [Optional API Considerations:] Additional Description: Signed-off-by: Yuchen Dai <[email protected]>
An quick fix is added formatted is not ready. Also the exceptions are listed below for track
|
The |
We can close this issue in favor of the merged PR above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I find my newly added header file not following the style guide
Header guards should use #pragma once.
Looks like this is not unique
I will blindly add the pragma directive to make the future include no-brain.
Do we need a rule formatter to check/fix after the above change?
The text was updated successfully, but these errors were encountered: