Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt: connection handler implementation #15126

Closed
lambdai opened this issue Feb 21, 2021 · 2 comments · Fixed by #15553 or #15815
Closed

tech debt: connection handler implementation #15126

lambdai opened this issue Feb 21, 2021 · 2 comments · Fixed by #15553 or #15815
Assignees

Comments

@lambdai
Copy link
Contributor

lambdai commented Feb 21, 2021

ConnectionHandlerImpl maintains the active listeners per worker thread.

Envoy has two categories of listener, tcp series and udp series. From the view of worker, both categories share the same interface: start, stop ...

It's a different story from the perspective of a listener.
Currently,

  1. udp listener put udp related function into ConnectionHandler interface.

  2. ActiveTcpListener is an internal class of ConnectionHandlerImpl and it depends on the implementation of ConnectionHandler instead of the interface. This is a huge pain. To test an ActiveTcpListener we have to push a long way from a listener config. It's hard to manipulate the internal state of a ActiveTcpListener obj, or a udp listener.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 24, 2021
@lambdai
Copy link
Contributor Author

lambdai commented Mar 24, 2021

wip

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Mar 25, 2021
ggreenway pushed a commit that referenced this issue Mar 25, 2021
Move active_tcp_listener out of conn handler.
Similar to #15349 but for tcp listener.
Fixes #15126

Signed-off-by: Yuchen Dai <[email protected]>
ggreenway pushed a commit that referenced this issue Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment