Make ENVOY_BUG only log critical in official debug builds

[asraa]

Given that WASM has been seeing ENVOY_BUG crashes, we should consider adding a compile time flag that makes ENVOY_BUG only log critical/increment stat and NOT abort, even in debug mode.

We may want release branches to be non-crashing in official debug releases for the next few releases until extensions are safe and ENVOY_BUG conditions are fixed.

See proxy-wasm/proxy-wasm-cpp-host#95

cc @PiotrSikora: If we view ENVOY_BUGs as at least as strong as ASSERTs, why shouldn't they crash in debug mode? ASSERTs are also subject to being buggy.

[PiotrSikora]

Note: it's not only Wasm but also ext_authz (and possibly ext_proc).

cc @PiotrSikora: If we view ENVOY_BUGs as at least as strong as ASSERTs, why shouldn't they crash in debug mode? ASSERTs are also subject to being buggy.

That's a very good point. It might be that we just only to fix this single buggy ENVOY_BUG.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

[bianpengyuan]

Can we please reopen this? Thanks!

[mattklein123]

I think per above we decided to just fix the buggy ENVOY_BUGs? Do we need to reopen this?

[PiotrSikora]

@mattklein123 yeah, but that didn't happen yet, so let's reopen until the offending ENVOY_BUG is fixed (see: #15496).