Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EDS failover endpoints #1354

Closed
htuch opened this issue Jul 30, 2017 · 1 comment
Closed

Add support for EDS failover endpoints #1354

htuch opened this issue Jul 30, 2017 · 1 comment
Assignees
Labels

Comments

@htuch
Copy link
Member

htuch commented Jul 30, 2017

See https://github.com/lyft/envoy-api/blob/master/api/eds.proto#L181.

@alyssawilk
Copy link
Contributor

Closing off in favor of #1929

htuch pushed a commit that referenced this issue Nov 30, 2017
Reworking the organization of endpoints from HostSets-with-localities to a tree with PrioritySets at the top and HostSets as nodes.
This allows the failover characteristics requested in #1929 as well as satisfying the defunct #1354
This will be followed up by a PR (or set of PRs) converting the load balancers over to use the new priority logic.

API Changes:
envoyproxy/data-plane-api#259

Risk Level: High
It's a pretty big refactor and there were some subtle gotchas (like stats initially updating before the backends)

Testing:
Current tests passing.
health checker unit tests verify all hosts are health checked across priority groups
outlier detection unit tests do the same for outlier detection.
upstream_impl_test.cc has unit testing basic priority set operations
load stats integration test extended for priorities. Verifies stats reporting insofar as there's now way to direct load yet, but the localities show up as expected.

Signed-off-by: Alyssa Wilk <[email protected]>
rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
Automatic merge from submit-queue.

Remove request.auth.user

**What this PR does / why we need it**:

Per authN policy design discussion, we want to keep only 2 principals for now (one for peer, and one for consolidate principal). This PR is to remove the request.auth.user attribute that was intended to keep origin principal.

Also note the peer principal attribute will be changed to source.principal (istio/istio#4689), but we will do it in separate PR.


`NONE`
jpsim pushed a commit that referenced this issue Nov 28, 2022
Description: exposes new functionality in the bridge layer that will leverage #1354.
Risk Level: low
Testing: updated tests

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this issue Nov 28, 2022
Description: adds a new SinkDelegate called LambdaDelegate which uses user-provided callbacks to drive log functionality.
Risk Level: low
Testing: new unit tests and integration test in main_interface_test.

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this issue Nov 29, 2022
Description: exposes new functionality in the bridge layer that will leverage #1354.
Risk Level: low
Testing: updated tests

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this issue Nov 29, 2022
Description: adds a new SinkDelegate called LambdaDelegate which uses user-provided callbacks to drive log functionality.
Risk Level: low
Testing: new unit tests and integration test in main_interface_test.

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants