-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format checking/fixing script breaks with python3.8 #12740
Comments
This applies to some of the other command line arguments like |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
I am running the same issue, and the fix from #12743 works for me, it'll be great for it to have it merged 🙌 |
) The formatting script does not recognize the variables from the command line arguments when running Python >=3.8 on MacOS due to changes in multiprocessing behavior in the new Python version (https://bugs.python.org/issue39931). This change passes in the command line arguments so they are accessible by the helper functions in which they are needed. Risk Level: Low Testing: Existing unit tests Docs Changes: N/A Release Notes: N/A Fixes #12740 Signed-off-by: Lisa Lu <[email protected]>
Description:
Running
tools/code_format/check_format.py check
(or withfix
) with python3.8.0 or python3.8.7 on MacOS fails with the following error:While the argument is correctly parsed into the
operation_type
variable in the main function it is undefined/not visible to the workers running checkFormat. I am guessing this behavior changed with Python3.8 (https://bugs.python.org/issue39931?) as I am able to run the script successfully with Python3.7.8 and older versions.The text was updated successfully, but these errors were encountered: