Skip to content

Commit

Permalink
add ratelimit log
Browse files Browse the repository at this point in the history
Signed-off-by: zirain <[email protected]>
  • Loading branch information
zirain committed Sep 15, 2021
1 parent a7b448c commit f3f3c15
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 3 additions & 1 deletion source/extensions/filters/common/ratelimit/ratelimit_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,11 @@ void GrpcClientImpl::onSuccess(
callbacks_ = nullptr;
}

void GrpcClientImpl::onFailure(Grpc::Status::GrpcStatus status, const std::string&,
void GrpcClientImpl::onFailure(Grpc::Status::GrpcStatus status, const std::string& msg,
Tracing::Span&) {
ASSERT(status != Grpc::Status::WellKnownGrpcStatus::Ok);
ENVOY_LOG_TO_LOGGER(Logger::Registry::getLog(Logger::Id::filter), debug,
"rate limit fail, status={} msg={}", status, msg);
callbacks_->complete(LimitStatus::Error, nullptr, nullptr, nullptr, EMPTY_STRING, nullptr);
callbacks_ = nullptr;
}
Expand Down
2 changes: 2 additions & 0 deletions source/extensions/filters/http/ratelimit/ratelimit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ void Filter::complete(Filters::Common::RateLimit::LimitStatus status,
cluster_->statsScope().counterFromStatName(stat_names.ok_).inc();
break;
case Filters::Common::RateLimit::LimitStatus::Error:
ENVOY_LOG_TO_LOGGER(Logger::Registry::getLog(Logger::Id::filter), debug,
"rate limit status, status={}", status);
cluster_->statsScope().counterFromStatName(stat_names.error_).inc();
break;
case Filters::Common::RateLimit::LimitStatus::OverLimit:
Expand Down

0 comments on commit f3f3c15

Please sign in to comment.