Skip to content

Commit

Permalink
Update QUICHE from f4ed5e0c7 to 0d70743fc (#35649)
Browse files Browse the repository at this point in the history
Update QUICHE from f4ed5e0c7 to 0d70743fc
    https://github.com/google/quiche/compare/f4ed5e0c7..0d70743fc
    
    
    2024-08-09 fayang No public description
2024-08-08 martinduke Refactor MoQ ChatClient to support end-to-end
tests and use moq_chat.h.
    2024-08-08 vasilvv Fix standalone QUICHE build.
2024-08-07 ricea Allocate memory less often in HttpHeaderBlock hash
function
    2024-08-07 martinduke Implement moq-chat server.
2024-08-07 birenroy Deprecates QUICHE reloadable flag
http2_add_hpack_overhead_bytes2.
    2024-08-07 bnc Update and simplify QUICHE platform documentation.
    2024-08-07 bnc Remove obsolete comment.
2024-08-07 birenroy Adds a way to reject messages with `obs-text` in
header field names.
2024-08-07 birenroy Reorders members of BalsaFrame, and uses a more
compact representation.
    2024-08-06 bnc Use kMetadataExtensionId directly in switch case.
    2024-08-06 bnc Modernize constants in http_protocol.h.
2024-08-06 fayang Set chrome_value to true for
gfe2_reloadable_flag_enable_h3_origin_frame.
    2024-08-06 quiche-dev Enabling rolled out flags.
2024-08-01 wub Fix //third_party/quic/core:quic_dispatcher_test with
Q046.
    2024-08-01 quiche-dev Add EVMB to Envoy QUIC connection options.
2024-08-01 wub QUIC TlsClientHandshaker: Demote some INFO logs to DLOG.
2024-07-31 wub Replace QUIC CID when the first INITIAL packet of a
connection is enqueued into the QuicBufferedPacketStore.
2024-07-31 martinduke Remove unused MoqtSession reference from
MoqtOutgoingQueue.
2024-07-31 bnc Add CookieCrumbling argument to QpackEncoder constructor,
and add QuicSpdySession::DisableCookieCrumbling() method.
2024-07-31 bnc Add ValueSplittingHeaderList option to disable cookie
crumbling during QPACK encoding.
2024-07-30 martinduke Restore operation of chat_client_bin after
draft-05 update.
2024-07-30 birenroy Updates //net/floo to refer to the new location of
some HTTP/2 libraries.
    2024-07-29 rch Add QUICHE support for the HTTP/3 ORIGIN frame.

Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

---------

Signed-off-by: Dan Zhang <[email protected]>
Co-authored-by: Dan Zhang <[email protected]>
  • Loading branch information
danzh2010 and danzh1989 authored Aug 9, 2024
1 parent 62b628b commit ee56715
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bazel/external/quiche.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1373,7 +1373,6 @@ envoy_cc_library(
name = "http2_core_headers_handler_interface_lib",
hdrs = [
"quiche/http2/core/spdy_headers_handler_interface.h",
"quiche/spdy/core/spdy_headers_handler_interface.h",
],
copts = quiche_copts,
repository = "@envoy",
Expand Down Expand Up @@ -3929,6 +3928,7 @@ envoy_quic_cc_library(
":quic_platform",
":quic_server_session_lib",
":quiche_common_callbacks",
":quiche_common_intrusive_list_lib",
":quiche_common_text_utils_lib",
],
)
Expand Down
6 changes: 3 additions & 3 deletions bazel/repository_locations.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1200,12 +1200,12 @@ REPOSITORY_LOCATIONS_SPEC = dict(
project_name = "QUICHE",
project_desc = "QUICHE (QUIC, HTTP/2, Etc) is Google‘s implementation of QUIC and related protocols",
project_url = "https://github.com/google/quiche",
version = "f4ed5e0c74485fb302367b833b8974373fed9e4c",
sha256 = "05e40b18e78b76a14bfa02eca1d6ebcf4c2ea0333c5db9fbe04287f912db2c20",
version = "0d70743fc056f254743082221eda54eba7431fa7",
sha256 = "b2c0ad26505d93416305618b5af10be35280a8d166c341f3e9795704914d1e12",
urls = ["https://github.com/google/quiche/archive/{version}.tar.gz"],
strip_prefix = "quiche-{version}",
use_category = ["controlplane", "dataplane_core"],
release_date = "2024-07-26",
release_date = "2024-08-09",
cpe = "N/A",
license = "BSD-3-Clause",
license_url = "https://github.com/google/quiche/blob/{version}/LICENSE",
Expand Down
4 changes: 2 additions & 2 deletions source/common/quic/envoy_quic_stream.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ std::unique_ptr<char[]> dataFromString(const std::string& str) {
void serializeMetadata(const Http::MetadataMapPtr& metadata, quic::QuicStreamId id,
absl::InlinedVector<quiche::QuicheMemSlice, 2>& slices) {
quic::NoopDecoderStreamErrorDelegate decoder_stream_error_delegate;
quic::QpackEncoder qpack_encoder(&decoder_stream_error_delegate,
quic::HuffmanEncoding::kDisabled);
quic::QpackEncoder qpack_encoder(&decoder_stream_error_delegate, quic::HuffmanEncoding::kDisabled,
quic::CookieCrumbling::kDisabled);

spdy::Http2HeaderBlock header_block;
for (const auto& [key, value] : *metadata) {
Expand Down
3 changes: 2 additions & 1 deletion test/common/quic/envoy_quic_h3_fuzz_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ class Delegate : public quic::QpackEncoder::DecoderStreamErrorDelegate {

static std::string encodeHeaders(const spdy::Http2HeaderBlock& headers) {
static Delegate delegate;
quic::QpackEncoder encoder(&delegate, quic::HuffmanEncoding::kEnabled);
quic::QpackEncoder encoder(&delegate, quic::HuffmanEncoding::kEnabled,
quic::CookieCrumbling::kEnabled);
return encoder.EncodeHeaderList(0, headers, nullptr);
}

Expand Down
3 changes: 2 additions & 1 deletion test/common/quic/test_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ std::string spdyHeaderToHttp3StreamPayload(const spdy::Http2HeaderBlock& header)
quic::test::NoopQpackStreamSenderDelegate encoder_stream_sender_delegate;
quic::NoopDecoderStreamErrorDelegate decoder_stream_error_delegate;
auto qpack_encoder = std::make_unique<quic::QpackEncoder>(&decoder_stream_error_delegate,
quic::HuffmanEncoding::kEnabled);
quic::HuffmanEncoding::kEnabled,
quic::CookieCrumbling::kEnabled);
qpack_encoder->set_qpack_stream_sender_delegate(&encoder_stream_sender_delegate);
// QpackEncoder does not use the dynamic table by default,
// therefore the value of |stream_id| does not matter.
Expand Down

0 comments on commit ee56715

Please sign in to comment.