release/ci: Fix Dockerhub publishing (#35966)

Fix #35954 Signed-off-by: Ryan Northey <[email protected]>
envoyproxy · Sep 4, 2024 · dbcee3e · dbcee3e
1 parent 6acedfa
commit dbcee3e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.github/workflows/_publish_build.yml b/.github/workflows/_publish_build.yml
@@ -6,6 +6,10 @@ permissions:
 on:
   workflow_call:
     secrets:
+      dockerhub-username:
+        required: false
+      dockerhub-password:
+        required: false
       gpg-key:
         required: true
       gpg-key-password:
@@ -128,6 +132,8 @@ jobs:
       source: |
         export NO_BUILD_SETUP=1
         export ENVOY_DOCKER_IN_DOCKER=1
+        export DOCKERHUB_USERNAME=${{ secrets.dockerhub-username }}
+        export DOCKERHUB_PASSWORD=${{ secrets.dockerhub-password }}
       trusted: ${{ inputs.trusted }}
       upload-name: docker
       upload-path: build_images

diff --git a/.github/workflows/envoy-publish.yml b/.github/workflows/envoy-publish.yml
@@ -55,6 +55,14 @@ jobs:
       contents: read
       packages: read
     secrets:
+      dockerhub-username: >-
+        ${{ fromJSON(needs.load.outputs.trusted)
+            && secrets.DOCKERHUB_USERNAME
+            || '' }}
+      dockerhub-password: >-
+        ${{ fromJSON(needs.load.outputs.trusted)
+            && secrets.DOCKERHUB_PASSWORD
+            || '' }}
       gpg-key: ${{ fromJSON(needs.load.outputs.trusted) && secrets.ENVOY_GPG_MAINTAINER_KEY || secrets.ENVOY_GPG_SNAKEOIL_KEY }}
       gpg-key-password: >-
         ${{ fromJSON(needs.load.outputs.trusted)