filters: rename config property (#955)

Description: Missed this request from @junr03 on #940. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <[email protected]> Signed-off-by: JP Simard <[email protected]>
envoyproxy · Nov 29, 2022 · b8340a1 · b8340a1
1 parent 6c0a024
commit b8340a1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/mobile/library/common/config_template.cc b/mobile/library/common/config_template.cc
@@ -35,7 +35,7 @@ const char* config_template = R"(
           - name: envoy.filters.http.platform_bridge
             typed_config:
               "@type": type.googleapis.com/envoymobile.extensions.filters.http.platform_bridge.PlatformBridge
-              name: PlatformStub
+              platform_filter_name: PlatformStub
           - name: envoy.filters.http.dynamic_forward_proxy
             typed_config:
               "@type": type.googleapis.com/envoy.extensions.filters.http.dynamic_forward_proxy.v3.FilterConfig

diff --git a/mobile/library/common/extensions/filters/http/platform_bridge/filter.cc b/mobile/library/common/extensions/filters/http/platform_bridge/filter.cc
@@ -32,8 +32,8 @@ Http::FilterHeadersStatus mapStatus(envoy_filter_headers_status_t status) {
 
 PlatformBridgeFilterConfig::PlatformBridgeFilterConfig(
     const envoymobile::extensions::filters::http::platform_bridge::PlatformBridge& proto_config)
-    : platform_filter_(
-          static_cast<envoy_http_filter*>(Api::External::retrieveApi(proto_config.name()))) {}
+    : platform_filter_(static_cast<envoy_http_filter*>(
+          Api::External::retrieveApi(proto_config.platform_filter_name()))) {}
 
 PlatformBridgeFilter::PlatformBridgeFilter(PlatformBridgeFilterConfigSharedPtr config)
     : platform_filter_(config->platform_filter()) {}

diff --git a/mobile/library/common/extensions/filters/http/platform_bridge/filter.proto b/mobile/library/common/extensions/filters/http/platform_bridge/filter.proto
@@ -5,5 +5,5 @@ package envoymobile.extensions.filters.http.platform_bridge;
 import "validate/validate.proto";
 
 message PlatformBridge {
-  string name = 1 [(validate.rules).string.min_bytes = 1];
+  string platform_filter_name = 1 [(validate.rules).string.min_bytes = 1];
 }