Skip to content

Commit

Permalink
Remove redundant Warn log in HTTP codec. (#18699) (#18702)
Browse files Browse the repository at this point in the history
This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to #18643.

Fixes #18643

Signed-off-by: Abhay Narayan Katare <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
  • Loading branch information
ankatare and mathetake authored Oct 29, 2021
1 parent 614ac4f commit 9d581d2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions docs/root/version_history/current.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Bug Fixes
---------
*Changes expected to improve the state of the world and are unlikely to have negative effects*

* http: remove redundant Warn log in HTTP codec.
* listener: fix a crash when updating any listener that does not bind to port.
* listener: listener add can reuse the listener socket of a draining filter chain listener and fix the request lost.

Expand Down
3 changes: 0 additions & 3 deletions source/common/http/codec_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ void CodecClient::onEvent(Network::ConnectionEvent event) {
StreamInfo::ResponseFlag::UpstreamProtocolError);
}
}
} else {
ENVOY_CONN_LOG(warn, "Connection is closed by {} during connecting.", *connection_,
(event == Network::ConnectionEvent::RemoteClose ? "peer" : "self"));
}
while (!active_requests_.empty()) {
// Fake resetting all active streams so that reset() callbacks get invoked.
Expand Down

0 comments on commit 9d581d2

Please sign in to comment.