Skip to content

Commit

Permalink
quic: reduce socket option header exposure (#16541)
Browse files Browse the repository at this point in the history
Move the inclusion of `socket_option_impl.h` from the header
to the source to reduce its exposure.

Signed-off-by: James Peach <[email protected]>
  • Loading branch information
jpeach authored May 19, 2021
1 parent bf3e6a2 commit 94d1137
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions source/common/quic/active_quic_listener.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@

#include <vector>

#include "common/runtime/runtime_features.h"
#include "common/http/utility.h"
#include "common/network/socket_option_impl.h"
#include "common/quic/envoy_quic_alarm_factory.h"
#include "common/quic/envoy_quic_connection_helper.h"
#include "common/quic/envoy_quic_dispatcher.h"
#include "common/quic/envoy_quic_packet_writer.h"
#include "common/quic/envoy_quic_proof_source.h"
#include "common/quic/envoy_quic_utils.h"
#include "common/quic/envoy_quic_packet_writer.h"
#include "common/quic/envoy_quic_utils.h"
#include "common/runtime/runtime_features.h"

namespace Envoy {
namespace Quic {
Expand Down
2 changes: 1 addition & 1 deletion source/common/quic/active_quic_listener.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
#include "envoy/config/listener/v3/quic_config.pb.h"
#include "envoy/network/connection_handler.h"
#include "envoy/network/listener.h"
#include "envoy/network/socket.h"
#include "envoy/runtime/runtime.h"

#include "common/network/socket_option_impl.h"
#include "common/protobuf/utility.h"
#include "common/quic/envoy_quic_dispatcher.h"
#include "common/runtime/runtime_protos.h"
Expand Down

0 comments on commit 94d1137

Please sign in to comment.