not impl emulate edge

Signed-off-by: Yuchen Dai <[email protected]>
envoyproxy · Jan 23, 2021 · 7a6b91a · 7a6b91a
1 parent e4c7e87
commit 7a6b91a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/source/extensions/io_socket/user_space/file_event_impl.h b/source/extensions/io_socket/user_space/file_event_impl.h
@@ -4,6 +4,7 @@
 
 #include "envoy/event/file_event.h"
 
+#include "common/common/assert.h"
 #include "common/event/dispatcher_impl.h"
 #include "common/event/event_impl_base.h"
 
@@ -28,16 +29,15 @@ class FileEventImpl final : public Event::FileEvent, Logger::Loggable<Logger::Id
 
   // This event always acts as edge triggered regardless the underlying OS is level or
   // edge triggered. The event owner on windows platform should not emulate edge events.
-  void unregisterEventIfEmulatedEdge(uint32_t) override {}
-  void registerEventIfEmulatedEdge(uint32_t) override {}
+  void unregisterEventIfEmulatedEdge(uint32_t) override { NOT_IMPLEMENTED_GCOVR_EXCL_LINE; }
+  void registerEventIfEmulatedEdge(uint32_t) override { NOT_IMPLEMENTED_GCOVR_EXCL_LINE; }
 
   // Notify events. Unlike activate() method, this method activates the given events only if the
   // events are enabled.
   void activateIfEnabled(uint32_t events);
 
 private:
   // This class maintains the ephemeral events and enabled events.
-  // getAndClearEphemeralEvents
   class EventListener {
   public:
     ~EventListener() = default;

diff --git a/test/extensions/io_socket/user_space/file_event_impl_test.cc b/test/extensions/io_socket/user_space/file_event_impl_test.cc
@@ -415,6 +415,14 @@ TEST_F(FileEventImplTest, EventClosedIsTriggeredByManullyActivate) {
     dispatcher_->run(Event::Dispatcher::RunType::NonBlock);
   }
 }
+
+TEST_F(FileEventImplTest, NotImplementedEmulatedEdge) {
+  user_file_event_ = std::make_unique<FileEventImpl>(
+      *dispatcher_, [this](uint32_t arg) { ready_cb_.called(arg); },
+      Event::FileReadyType::Write | Event::FileReadyType::Closed, io_source_);
+  EXPECT_DEATH({ user_file_event_->registerEventIfEmulatedEdge(0); }, "not implemented");
+  EXPECT_DEATH({ user_file_event_->unregisterEventIfEmulatedEdge(0); }, "not implemented");
+}
 } // namespace
 } // namespace UserSpace
 } // namespace IoSocket